From 41c9adffc6fa30eca059d2dd90e28b3951d6f6cf Mon Sep 17 00:00:00 2001 From: "yurys@chromium.org" Date: Wed, 3 Jul 2013 14:23:34 +0000 Subject: [PATCH] Relax test expectations for test-cpu-profiler/FunctionApplySample The profile may look a bit different on the bots (see below). We expected this only under GC stress testing, the change makes regular expectations the same. [Top down]: 68 0 (root) [-1] #0 1 1 1 (program) [-1] #0 2 67 65 start [-1] #16 3 2 0 (unresolved function) [-1] #0 4 2 2 apply [-1] #0 5 BUG=None TBR=jkummerow@chromium.org Review URL: https://codereview.chromium.org/18331012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15470 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- test/cctest/test-cpu-profiler.cc | 7 ------- 1 file changed, 7 deletions(-) diff --git a/test/cctest/test-cpu-profiler.cc b/test/cctest/test-cpu-profiler.cc index 97636a35ff..0ae1a9ef7e 100644 --- a/test/cctest/test-cpu-profiler.cc +++ b/test/cctest/test-cpu-profiler.cc @@ -1169,13 +1169,7 @@ TEST(FunctionApplySample) { CheckChildrenNames(root, names); } - // In case of GC stress tests all samples may be in GC phase and there - // won't be |start| node in the profile. - bool is_gc_stress_testing = - (i::FLAG_gc_interval != -1) || i::FLAG_stress_compaction; - const v8::CpuProfileNode* startNode = FindChild(root, "start"); - CHECK(is_gc_stress_testing || startNode); if (startNode) { { ScopedVector > names(2); @@ -1185,7 +1179,6 @@ TEST(FunctionApplySample) { } const v8::CpuProfileNode* testNode = FindChild(startNode, "test"); - CHECK(is_gc_stress_testing || testNode); if (testNode) { ScopedVector > names(2); names[0] = v8::String::New("bar");