AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[turbofan] Remove dead code from SimplifiedLowering.

Browse Source 
This is follow-up cleanup for the flags that are no longer used inside
SimplifiedLowering.

R=jarin@chromium.org

Review-Url: https://codereview.chromium.org/2132403002
Cr-Commit-Position: refs/heads/master@{#37652}
This commit is contained in:
bmeurer 2016-07-11 09:04:14 -07:00 committed by Commit bot
parent b030a6f59d
commit 42c296487e
3 changed files with 3 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/compiler/pipeline.cc
View File

@ -939,12 +939,8 @@ struct RepresentationSelectionPhase {
static const char* phase_name() { return "representation selection"; } static const char* phase_name() { return "representation selection"; }
void Run(PipelineData* data, Zone* temp_zone) { void Run(PipelineData* data, Zone* temp_zone) {
SimplifiedLowering::Flags flags =
data->info()->is_type_feedback_enabled()
? SimplifiedLowering::kTypeFeedbackEnabled
: SimplifiedLowering::kNoFlag;
SimplifiedLowering lowering(data->jsgraph(), temp_zone, SimplifiedLowering lowering(data->jsgraph(), temp_zone,
data->source_positions(), flags); data->source_positions());
lowering.LowerAllNodes(); lowering.LowerAllNodes();
} }
}; };

4
src/compiler/simplified-lowering.cc
View File

@ -2335,12 +2335,10 @@ class RepresentationSelector {
}; };
SimplifiedLowering::SimplifiedLowering(JSGraph* jsgraph, Zone* zone, SimplifiedLowering::SimplifiedLowering(JSGraph* jsgraph, Zone* zone,
SourcePositionTable* source_positions, SourcePositionTable* source_positions)
Flags flags)
: jsgraph_(jsgraph), : jsgraph_(jsgraph),
zone_(zone), zone_(zone),
type_cache_(TypeCache::Get()), type_cache_(TypeCache::Get()),
flags_(flags),
source_positions_(source_positions) {} source_positions_(source_positions) {}
void SimplifiedLowering::LowerAllNodes() { void SimplifiedLowering::LowerAllNodes() {

9
src/compiler/simplified-lowering.h
View File

@ -5,7 +5,6 @@
#ifndef V8_COMPILER_SIMPLIFIED_LOWERING_H_ #ifndef V8_COMPILER_SIMPLIFIED_LOWERING_H_
#define V8_COMPILER_SIMPLIFIED_LOWERING_H_ #define V8_COMPILER_SIMPLIFIED_LOWERING_H_
#include "src/base/flags.h"
#include "src/compiler/js-graph.h" #include "src/compiler/js-graph.h"
#include "src/compiler/machine-operator.h" #include "src/compiler/machine-operator.h"
#include "src/compiler/node.h" #include "src/compiler/node.h"
@ -27,11 +26,8 @@ class SourcePositionTable;
class SimplifiedLowering final { class SimplifiedLowering final {
public: public:
enum Flag { kNoFlag = 0u, kTypeFeedbackEnabled = 1u << 0 };
typedef base::Flags<Flag> Flags;
SimplifiedLowering(JSGraph* jsgraph, Zone* zone, SimplifiedLowering(JSGraph* jsgraph, Zone* zone,
SourcePositionTable* source_positions, SourcePositionTable* source_positions);
Flags flags = kNoFlag);
~SimplifiedLowering() {} ~SimplifiedLowering() {}
void LowerAllNodes(); void LowerAllNodes();
@ -47,15 +43,12 @@ class SimplifiedLowering final {
void DoStoreBuffer(Node* node); void DoStoreBuffer(Node* node);
void DoShift(Node* node, Operator const* op, Type* rhs_type); void DoShift(Node* node, Operator const* op, Type* rhs_type);
Flags flags() const { return flags_; }
private: private:
JSGraph* const jsgraph_; JSGraph* const jsgraph_;
Zone* const zone_; Zone* const zone_;
TypeCache const& type_cache_; TypeCache const& type_cache_;
SetOncePointer<Node> to_number_code_; SetOncePointer<Node> to_number_code_;
SetOncePointer<Operator const> to_number_operator_; SetOncePointer<Operator const> to_number_operator_;
Flags flags_;
// TODO(danno): SimplifiedLowering shouldn't know anything about the source // TODO(danno): SimplifiedLowering shouldn't know anything about the source
// positions table, but must for now since there currently is no other way to // positions table, but must for now since there currently is no other way to