AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Let v8's configs have an effect in 64-bit Windows Chromium builds.

Browse Source 
The Chromium 64-bit Windows build uses "Debug_x64" and "Release_x64"
as configs for some reason, so put v8's build config settings there
too.

Reduces e.g. the runtime of CrSettingsBrowserTest.CrSettingsTest from
25s to 12s on my z840 in a 64-bit Chromium debug build
(while also turning on handle zapping).

BUG=chromium:586511
LOG=n

Review URL: https://codereview.chromium.org/1852913002

Cr-Commit-Position: refs/heads/master@{#35224}
This commit is contained in:
thakis 2016-04-03 06:08:34 -07:00 committed by Commit bot
parent f5a95d2b59
commit 42f2261cfe
1 changed files with 23 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
build/toolchain.gypi
View File

@ -1287,7 +1287,8 @@
}],
],
}, # Debug
'Release': {
'ReleaseBase': {
'abstract': 1,
'variables': {
'v8_enable_slow_dchecks%': 0,
},
@ -1367,6 +1368,27 @@
}],
], # conditions
}, # Release
'Release': {
'inherit_from': ['ReleaseBase'],
}, # Debug
'conditions': [
[ 'OS=="win"', {
# TODO(bradnelson): add a gyp mechanism to make this more graceful.
'Debug_x64': {
'inherit_from': ['DebugBaseCommon'],
'conditions': [
['v8_optimized_debug==0', {
'inherit_from': ['DebugBase0'],
}, {
'inherit_from': ['DebugBase1'],
}],
],
},
'Release_x64': {
'inherit_from': ['ReleaseBase'],
},
}],
],
}, # configurations
}, # target_defaults
}