AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[cleanup] Cleanup StringStream::PrintFunction()

Browse Source 
... by removing the unused Code* argument.

Bug: v8:11880
Change-Id: Icec0c448e844a371ec1751a30419f79dc11876d8
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3777717
Auto-Submit: Igor Sheludko <ishell@chromium.org>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Igor Sheludko <ishell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#81868}
This commit is contained in:
ishell@chromium.org 2022-07-21 13:56:59 +02:00 committed by V8 LUCI CQ
parent 9e45c43327
commit 43dc9d5fc5
3 changed files with 8 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/execution/frames.cc
View File

@ -987,9 +987,8 @@ void BuiltinExitFrame::Print(StringStream* accumulator, PrintMode mode,
accumulator->PrintSecurityTokenIfChanged(function);
PrintIndex(accumulator, mode, index);
accumulator->Add("builtin exit frame: ");
Code code;
if (IsConstructor()) accumulator->Add("new ");
accumulator->PrintFunction(function, receiver, &code);
accumulator->PrintFunction(function, receiver);
accumulator->Add("(this=%o", receiver);
@ -2364,9 +2363,8 @@ void WasmCompileLazyFrame::Iterate(RootVisitor* v) const {
namespace {
void PrintFunctionSource(StringStream* accumulator, SharedFunctionInfo shared,
Code code) {
if (FLAG_max_stack_trace_source_length != 0 && !code.is_null()) {
void PrintFunctionSource(StringStream* accumulator, SharedFunctionInfo shared) {
if (FLAG_max_stack_trace_source_length != 0) {
std::ostringstream os;
os << "--------- s o u r c e c o d e ---------\n"
<< SourceCodeOf(shared, FLAG_max_stack_trace_source_length)
@ -2389,9 +2387,8 @@ void JavaScriptFrame::Print(StringStream* accumulator, PrintMode mode,
accumulator->PrintSecurityTokenIfChanged(function);
PrintIndex(accumulator, mode, index);
PrintFrameKind(accumulator);
Code code;
if (IsConstructor()) accumulator->Add("new ");
accumulator->PrintFunction(function, receiver, &code);
accumulator->PrintFunction(function, receiver);
accumulator->Add(" [%p]", function);
// Get scope information for nicer output, if possible. If code is nullptr, or
@ -2437,7 +2434,7 @@ void JavaScriptFrame::Print(StringStream* accumulator, PrintMode mode,
}
if (is_optimized()) {
accumulator->Add(" {\n// optimized frame\n");
PrintFunctionSource(accumulator, *shared, code);
PrintFunctionSource(accumulator, *shared);
accumulator->Add("}\n");
return;
}
@ -2487,7 +2484,7 @@ void JavaScriptFrame::Print(StringStream* accumulator, PrintMode mode,
accumulator->Add(" [%02d] : %o\n", i, GetExpression(i));
}
PrintFunctionSource(accumulator, *shared, code);
PrintFunctionSource(accumulator, *shared);
accumulator->Add("}\n\n");
}

3
src/strings/string-stream.cc
View File

@ -406,9 +406,8 @@ void StringStream::PrintSecurityTokenIfChanged(JSFunction fun) {
}
}
void StringStream::PrintFunction(JSFunction fun, Object receiver, Code* code) {
void StringStream::PrintFunction(JSFunction fun, Object receiver) {
PrintPrototype(fun, receiver);
*code = FromCodeT(fun.code());
}
void StringStream::PrintPrototype(JSFunction fun, Object receiver) {

3
src/strings/string-stream.h
View File

@ -181,8 +181,7 @@ class StringStream final {
void PrintUsingMap(JSObject js_object);
void PrintPrototype(JSFunction fun, Object receiver);
void PrintSecurityTokenIfChanged(JSFunction function);
// NOTE: Returns the code in the output parameter.
void PrintFunction(JSFunction function, Object receiver, Code* code);
void PrintFunction(JSFunction function, Object receiver);
// Reset the stream.
void Reset() {