AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[flags] Remove unused FLAG_log_handles and related code

Browse Source 
Change-Id: I97d29623e163ceee450814f03fba745d478082ff
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3574550
Auto-Submit: Camillo Bruni <cbruni@chromium.org>
Reviewed-by: Marja Hölttä <marja@chromium.org>
Commit-Queue: Marja Hölttä <marja@chromium.org>
Cr-Commit-Position: refs/heads/main@{#79839}
This commit is contained in:
Camillo Bruni 2022-04-06 22:57:40 +02:00 committed by V8 LUCI CQ
parent 9ba6aff285
commit 440235638d
4 changed files with 0 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/flags/flag-definitions.h
View File

@ -2016,7 +2016,6 @@ DEFINE_BOOL(log_code, false,
DEFINE_BOOL(log_code_disassemble, false,
"Log all disassembled code to the log file.")
DEFINE_IMPLICATION(log_code_disassemble, log_code)
DEFINE_BOOL(log_handles, false, "Log global handle events.")
DEFINE_BOOL(log_source_code, false, "Log source code.")
DEFINE_BOOL(log_function_events, false,
"Log function events "

1
src/init/v8.cc
View File

@ -138,7 +138,6 @@ void V8::Initialize() {
&FLAG_log_api,
&FLAG_log_code,
&FLAG_log_code_disassemble,
&FLAG_log_handles,
&FLAG_log_source_code,
&FLAG_log_function_events,
&FLAG_log_internal_timer_events,

7
src/logging/log.cc
View File

@ -1074,13 +1074,6 @@ void Logger::IntPtrTEvent(const char* name, intptr_t value) {
msg.WriteToLogFile();
}
void Logger::HandleEvent(const char* name, Address* location) {
if (!FLAG_log_handles) return;
MSG_BUILDER();
msg << name << kNext << reinterpret_cast<void*>(location);
msg.WriteToLogFile();
}
void Logger::WriteApiSecurityCheck() {
DCHECK(FLAG_log_api);
MSG_BUILDER();

3
src/logging/log.h
View File

@ -141,9 +141,6 @@ class Logger : public CodeEventListener {
// Emits an event with an int value -> (name, value).
void IntPtrTEvent(const char* name, intptr_t value);
// Emits an event with an handle value -> (name, location).
void HandleEvent(const char* name, Address* location);
// Emits memory management events for C allocated structures.
void NewEvent(const char* name, void* object, size_t size);
void DeleteEvent(const char* name, void* object);