AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[heap] Update verification of LO_SPACE in SizeOfInitialHeap

Browse Source 
On PPC64 linux the OS page size is 64KB, therefore when the
snapshot is created the serialized heap already has LO_SPACE
allocated(the allocation goes beyond the 1st page of
CODE_SPACE and hence LO_SPACE is allocated).
I've updated the testcase to check if the delta
of the LO_SPACE is zero.

R=mlippautz@chromium.org, ulan@chromium.org, vogelheim@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2394893002
Cr-Commit-Position: refs/heads/master@{#40014}
This commit is contained in:
bjaideep 2016-10-05 12:47:11 -07:00 committed by Commit bot
parent e901ccdd18
commit 45b64d15a0
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
test/cctest/heap/test-spaces.cc
View File

@ -500,6 +500,8 @@ TEST(SizeOfInitialHeap) {
->IsUndefined()) {
return;
}
// Initial size of LO_SPACE
size_t initial_lo_space = isolate->heap()->lo_space()->Size();
// The limit for each space for an empty isolate containing just the
// snapshot.
@ -528,7 +530,7 @@ TEST(SizeOfInitialHeap) {
}
// No large objects required to perform the above steps.
CHECK(isolate->heap()->lo_space()->IsEmpty());
CHECK_EQ(initial_lo_space, isolate->heap()->lo_space()->Size());
}
static HeapObject* AllocateUnaligned(NewSpace* space, int size) {