AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Use 1ms CPU profiler sampling interval on Android by default

Browse Source 
This CL changes default sampling interval on Android from 5ms to 1ms so that it is the same on all platforms. All perf tests on modern devices (Galaxy Nexus, Nexus 7) show that 1ms should be long enough for profiling on mobile devices.

BUG=None
R=bmeurer@chromium.org, loislo@chromium.org

Review URL: https://codereview.chromium.org/23927005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16526 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
yurys@chromium.org 2013-09-04 12:38:17 +00:00
parent c034bb48b5
commit 45d6ef065e
1 changed files with 1 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/flag-definitions.h
View File

@ -455,16 +455,8 @@ DEFINE_bool(compilation_cache, true, "enable compilation cache")
DEFINE_bool(cache_prototype_transitions, true, "cache prototype transitions")
// cpu-profiler.cc
#if defined(ANDROID)
// Phones and tablets have processors that are much slower than desktop
// and laptop computers for which current heuristics are tuned.
#define DEFAULT_INTERVAL 5000
#else
#define DEFAULT_INTERVAL 1000
#endif
DEFINE_int(cpu_profiler_sampling_interval, DEFAULT_INTERVAL,
DEFINE_int(cpu_profiler_sampling_interval, 1000,
"CPU profiler sampling interval in microseconds")
#undef DEFAULT_INTERVAL
// debug.cc
DEFINE_bool(trace_debug_json, false, "trace debugging JSON request/response")