PPC: Clean up JSConstructStub
Port 882055ff6a
Original commit message:
- fix truthfulness of comments
- use InitializeFieldsWithFiller more consistently
- use unsigned comparisons for pointers
No change in functionality intended.
Bonus: improve JavaScriptFrame::Print() for an enhanced debugging experience:
- print PC of each frame
- print the function's source also for optimized frames
R=dstence@us.ibm.com, michael_dawson@ca.ibm.com
BUG=
Review URL: https://codereview.chromium.org/1193363004
Cr-Commit-Position: refs/heads/master@{#29197}
This commit is contained in:
parent
40ec8e1db0
commit
464f05385e
@ -439,7 +439,7 @@ static void Generate_JSConstructStubHelper(MacroAssembler* masm,
|
||||
// initial map and properties and elements are set to empty fixed array.
|
||||
// r4: constructor function
|
||||
// r5: initial map
|
||||
// r6: object size (not including memento if create_memento)
|
||||
// r6: object size (including memento if create_memento)
|
||||
// r7: JSObject (not tagged)
|
||||
__ LoadRoot(r9, Heap::kEmptyFixedArrayRootIndex);
|
||||
__ mr(r8, r7);
|
||||
@ -516,7 +516,7 @@ static void Generate_JSConstructStubHelper(MacroAssembler* masm,
|
||||
__ addi(r7, r7, Operand(kHeapObjectTag));
|
||||
|
||||
// Check if a non-empty properties array is needed. Continue with
|
||||
// allocated object if not fall through to runtime call if it is.
|
||||
// allocated object if not; allocate and initialize a FixedArray if yes.
|
||||
// r4: constructor function
|
||||
// r7: JSObject
|
||||
// r8: start of next object (not tagged)
|
||||
|
Loading…
Reference in New Issue
Block a user