AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[arraybuffer] Uncomment test/mjsunit/harmony/sharedarraybuffer.js

Browse Source 
R=binji@chromium.org

Change-Id: I936d906be90c0c6d3b84b5ad4e8cb574ab8cd970
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1585851
Commit-Queue: Ben Titzer <titzer@chromium.org>
Reviewed-by: Ben Smith <binji@chromium.org>
Cr-Commit-Position: refs/heads/master@{#61135}
This commit is contained in:
Ben L. Titzer 2019-04-30 18:22:26 +02:00 committed by Commit Bot
parent 813d149e17
commit 475124b68d
4 changed files with 16 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
test/mjsunit/es6/typedarray-neutered.js → test/mjsunit/es6/typedarray-detached.js
View File

@ -26,11 +26,9 @@ function TestArrayBufferCreation() {
assertThrows(function() { new ArrayBuffer(-10); }, RangeError);
assertThrows(function() { new ArrayBuffer(-2.567); }, RangeError);
/* TODO[dslomov]: Reenable the test
assertThrows(function() {
var ab1 = new ArrayBuffer(0xFFFFFFFFFFFF)
}, RangeError);
*/
var ab = new ArrayBuffer();
assertSame(0, ab.byteLength);
@ -612,10 +610,9 @@ function TestTypedArraysWithIllegalIndicesStrict() {
assertEquals(255, a[s2]);
assertEquals(0, a[-0]);
/* Chromium bug: 424619
* a[-Infinity] = 50;
* assertEquals(undefined, a[-Infinity]);
*/
a[-Infinity] = 50;
assertEquals(undefined, a[-Infinity]);
a[1.5] = 10;
assertEquals(undefined, a[1.5]);
var nan = Math.sqrt(-1);

6
test/mjsunit/es6/typedarray-tostring.js
View File

@ -71,10 +71,8 @@ for (var constructor of typedArrayConstructors) {
assertEquals("1,2,3", o1.join());
assertEquals("1,2,3", o1.toString());
assertThrows(function() { o1.toLocaleString() }, TypeError);
// TODO(littledan): Use the same function for TypedArray as for
// Array, as the spec says (but Firefox doesn't do either).
// Currently, using the same method leads to a bootstrap failure.
// assertEquals(o1.toString, Array.prototype.toString);
assertEquals(o1.toString, Array.prototype.toString);
// Redefining length does not change result
var a5 = new constructor([1, 2, 3])

10
test/mjsunit/es6/typedarray.js
View File

@ -46,11 +46,9 @@ function TestArrayBufferCreation() {
assertThrows(function() { new ArrayBuffer(-10); }, RangeError);
assertThrows(function() { new ArrayBuffer(-2.567); }, RangeError);
/* TODO[dslomov]: Reenable the test
assertThrows(function() {
var ab1 = new ArrayBuffer(0xFFFFFFFFFFFF)
}, RangeError);
*/
var ab = new ArrayBuffer();
assertSame(0, ab.byteLength);
@ -815,10 +813,10 @@ function TestTypedArraysWithIllegalIndicesStrict() {
assertEquals(255, a[s2]);
assertEquals(0, a[-0]);
/* Chromium bug: 424619
* a[-Infinity] = 50;
* assertEquals(undefined, a[-Infinity]);
*/
a[-Infinity] = 50;
assertEquals(undefined, a[-Infinity]);
a[1.5] = 10;
assertEquals(undefined, a[1.5]);
var nan = Math.sqrt(-1);

17
test/mjsunit/harmony/sharedarraybuffer.js
View File

@ -47,11 +47,9 @@ function TestArrayBufferCreation() {
assertThrows(function() { new SharedArrayBuffer(-10); }, RangeError);
assertThrows(function() { new SharedArrayBuffer(-2.567); }, RangeError);
/* TODO[dslomov]: Reenable the test
assertThrows(function() {
var ab1 = new SharedArrayBuffer(0xFFFFFFFFFFFF)
}, RangeError);
*/
var sab = new SharedArrayBuffer();
assertSame(0, sab.byteLength);
@ -450,10 +448,10 @@ function TestTypedArraysWithIllegalIndices() {
assertEquals(255, a[s2]);
assertEquals(0, a[-0]);
/* Chromium bug: 424619
* a[-Infinity] = 50;
* assertEquals(undefined, a[-Infinity]);
*/
a[-Infinity] = 50;
assertEquals(undefined, a[-Infinity]);
a[1.5] = 10;
assertEquals(undefined, a[1.5]);
var nan = Math.sqrt(-1);
@ -499,10 +497,9 @@ function TestTypedArraysWithIllegalIndicesStrict() {
assertEquals(255, a[s2]);
assertEquals(0, a[-0]);
/* Chromium bug: 424619
* a[-Infinity] = 50;
* assertEquals(undefined, a[-Infinity]);
*/
a[-Infinity] = 50;
assertEquals(undefined, a[-Infinity]);
a[1.5] = 10;
assertEquals(undefined, a[1.5]);
var nan = Math.sqrt(-1);