AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Revert "Reland "[compiler] Replace Symbol with direct reads""

Browse Source 
This reverts commit 7ce5dd6e5a.

Reason for revert: Clusterfuzz saw an issue, which is an m87 blocker.
Reverting and will re-assess & reland later.

Bug: v8:7790, chromium:1137594

Original change's description:
> Reland "[compiler] Replace Symbol with direct reads"
>
> This is a reland of d3b295fa52
>
> Got speculatively reverted in https://crrev.com/c/v8/v8/+/2403256 but
> doesn't seem to have been causing the TSAN failures
>
> Original change's description:
> > [compiler] Replace Symbol with direct reads
> >
> > Bug: v8:7790
> > Change-Id: I49120a6349777fd992a97d697940e79b2e71dbd1
> > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2400988
> > Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org>
> > Reviewed-by: Georg Neis <neis@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#69812}
>
> Bug: v8:7790
> Change-Id: I459f4bfc881c641258dcc46fc55fce21f9e03dec
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2403921
> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org>
> Commit-Queue: Georg Neis <neis@chromium.org>
> Auto-Submit: Santiago Aboy Solanes <solanes@chromium.org>
> Reviewed-by: Georg Neis <neis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#69822}

TBR=neis@chromium.org,solanes@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: v8:7790
Change-Id: Iec7d708510702a9168c6ad9a7373584f107af739
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2502333
Reviewed-by: Santiago Aboy Solanes <solanes@chromium.org>
Reviewed-by: Michael Stanton <mvstanton@chromium.org>
Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org>
Commit-Queue: Michael Stanton <mvstanton@chromium.org>
Auto-Submit: Santiago Aboy Solanes <solanes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#70798}
This commit is contained in:
Santiago Aboy Solanes 2020-10-27 12:44:48 +00:00 committed by Commit Bot
parent 2288b1f638
commit 47ea5fb6eb
2 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/compiler/heap-refs.h
View File

@ -61,8 +61,6 @@ enum class OddballType : uint8_t {
/* Subtypes of FixedArray */ \
V(ObjectBoilerplateDescription) \
V(ScopeInfo) \
/* Subtypes of Name */ \
V(Symbol) \
/* Subtypes of HeapObject */ \
V(AccessorInfo) \
V(ArrayBoilerplateDescription) \
@ -94,6 +92,7 @@ enum class OddballType : uint8_t {
/* Subtypes of Name */ \
V(InternalizedString) \
V(String) \
V(Symbol) \
/* Subtypes of JSReceiver */ \
V(JSObject) \
/* Subtypes of HeapObject */ \

4
src/compiler/js-heap-broker.cc
View File

@ -850,9 +850,7 @@ class StringData : public NameData {
class SymbolData : public NameData {
public:
SymbolData(JSHeapBroker* broker, ObjectData** storage, Handle<Symbol> object)
: NameData(broker, storage, object) {
DCHECK(!FLAG_turbo_direct_heap_access);
}
: NameData(broker, storage, object) {}
};
namespace {