AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[compiler] Perform GetFieldIndexFor concurrently through Refs

Browse Source 
Bug: v8:7790
Change-Id: I8ff80b109381b339864879e8e4e0dc0d5e418262
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2682636
Reviewed-by: Georg Neis <neis@chromium.org>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#73074}
This commit is contained in:
Santiago Aboy Solanes 2021-02-25 15:47:06 +00:00 committed by Commit Bot
parent 63dc18c09f
commit 48406979d2
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/compiler/js-heap-broker.cc
View File

@ -3117,12 +3117,12 @@ FeedbackCellRef FeedbackVectorRef::GetClosureFeedbackCell(int index) const {
}
ObjectRef JSObjectRef::RawFastPropertyAt(FieldIndex index) const {
CHECK(index.is_inobject());
if (data_->should_access_heap()) {
return ObjectRef(broker(), broker()->CanonicalPersistentHandle(
object()->RawFastPropertyAt(index)));
}
JSObjectData* object_data = data()->AsJSObject();
CHECK(index.is_inobject());
return ObjectRef(broker(),
object_data->GetInobjectField(index.property_index()));
}
@ -3167,12 +3167,16 @@ void JSObjectRef::EnsureElementsTenured() {
FieldIndex MapRef::GetFieldIndexFor(InternalIndex descriptor_index) const {
CHECK_LT(descriptor_index.as_int(), NumberOfOwnDescriptors());
if (data_->should_access_heap()) {
return FieldIndex::ForDescriptor(*object(), descriptor_index);
if (data_->should_access_heap() || FLAG_turbo_direct_heap_access) {
FieldIndex result = FieldIndex::ForDescriptor(*object(), descriptor_index);
DCHECK(result.is_inobject());
return result;
}
DescriptorArrayData* descriptors =
data()->AsMap()->instance_descriptors()->AsDescriptorArray();
return descriptors->GetFieldIndexFor(descriptor_index);
FieldIndex result = descriptors->GetFieldIndexFor(descriptor_index);
DCHECK(result.is_inobject());
return result;
}
int MapRef::GetInObjectPropertyOffset(int i) const {