AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[clang-tidy] Make deleted member functions public

Browse Source 
Making them private was a way to hide the functions, we can
explicitly delete them, which give a better compilation error message as
well.

Also see: https://stackoverflow.com/q/55205874

Bug: v8:10488
Change-Id: I0d185063e6e282109627f25b732108905ed36833
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2223233
Reviewed-by: Anton Bikineev <bikineev@chromium.org>
Commit-Queue: Zhi An Ng <zhin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#68314}
This commit is contained in:
Ng Zhi An 2020-05-29 22:40:49 -07:00 committed by Commit Bot
parent a70a359d41
commit 485313f5c5
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/heap/finalization-registry-cleanup-task.h
View File

@ -18,12 +18,11 @@ class FinalizationRegistryCleanupTask : public CancelableTask {
public:
explicit FinalizationRegistryCleanupTask(Heap* heap);
~FinalizationRegistryCleanupTask() override = default;
private:
FinalizationRegistryCleanupTask(const FinalizationRegistryCleanupTask&) =
delete;
void operator=(const FinalizationRegistryCleanupTask&) = delete;
private:
void RunInternal() override;
void SlowAssertNoActiveJavaScript();