AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[fuchsia] Reland: Migrate d8 to a component framework v2 Fuchsia component

Browse Source 
In the process, switch to using the Fuchsia GN SDK templates for
building the component and package.

gni/v8.cmx is retained temporarily until out-of-tree consumers have been
updated.

Bug: v8:12589
Change-Id: If08cfcbf579696482e7cd60a8b8b80bcc4c7dab2
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3885881
Auto-Submit: Greg Thompson <grt@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Reviewed-by: Alexander Schulze <alexschulze@chromium.org>
Cr-Commit-Position: refs/heads/main@{#83106}
This commit is contained in:
Greg Thompson 2022-09-09 10:11:03 +02:00 committed by V8 LUCI CQ
parent cfca972e10
commit 48a5114450
3 changed files with 36 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
BUILD.gn
View File

@ -6385,18 +6385,25 @@ group("v8_archive") {
# TODO(dglazkov): Remove the "!build_with_chromium" condition once this clause # TODO(dglazkov): Remove the "!build_with_chromium" condition once this clause
# is removed from Chromium. # is removed from Chromium.
if (is_fuchsia && !build_with_chromium) { if (is_fuchsia && !build_with_chromium) {
import("//build/config/fuchsia/rules.gni") import("//build/config/fuchsia/generate_runner_scripts.gni")
import("//third_party/fuchsia-sdk/sdk/build/component.gni")
import("//third_party/fuchsia-sdk/sdk/build/package.gni")
cr_fuchsia_package("d8_fuchsia_pkg") { fuchsia_component("d8_component") {
testonly = true testonly = true
binary = ":d8" manifest = "gni/v8.cml"
manifest = "gni/v8.cmx" data_deps = [ ":d8" ]
package_name_override = "d8" }
fuchsia_package("d8_pkg") {
testonly = true
package_name = "d8"
deps = [ ":d8_component" ]
} }
fuchsia_package_installer("d8_fuchsia") { fuchsia_package_installer("d8_fuchsia") {
testonly = true testonly = true
package = ":d8_fuchsia_pkg" package = ":d8_pkg"
package_name = "d8" package_name = "d8"
} }
} }

3
gni/OWNERS
View File

@ -1,5 +1,6 @@
file:../INFRA_OWNERS file:../INFRA_OWNERS
per-file v8.cml=victorgomes@chromium.org
per-file v8.cmx=victorgomes@chromium.org per-file v8.cmx=victorgomes@chromium.org
per-file release_branch_toggle.gni=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com per-file release_branch_toggle.gni=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com
per-file release_branch_toggle.gni=vahl@chromium.org per-file release_branch_toggle.gni=vahl@chromium.org

21
gni/v8.cml Normal file
View File

@ -0,0 +1,21 @@
// Copyright 2022 The V8 project authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
{
include: [ "syslog/client.shard.cml" ],
program: {
runner: "elf",
binary: "d8",
},
use: [
{
protocol: [
"fuchsia.kernel.VmexResource",
],
},
{
storage: "tmp",
path: "/tmp",
},
],
}