AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[api] Use v8_flags for accessing flag values

Browse Source 
Avoid the deprecated FLAG_* syntax, access flag values via the
{v8_flags} struct instead.

R=jkummerow@chromium.org

Bug: v8:12887
Change-Id: Ia17d668b3ddcbcb7a35388231aa5d80e8e5b419b
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3899122
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/main@{#83270}
This commit is contained in:
Clemens Backes 2022-09-16 12:47:26 +02:00 committed by V8 LUCI CQ
parent 488b0ff1f5
commit 498cc55cd4
2 changed files with 31 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/api/api-natives.cc
View File

@ -529,7 +529,7 @@ MaybeHandle<JSFunction> InstantiateFunction(
if (!data->needs_access_check() && if (!data->needs_access_check() &&
data->GetNamedPropertyHandler().IsUndefined(isolate) && data->GetNamedPropertyHandler().IsUndefined(isolate) &&
data->GetIndexedPropertyHandler().IsUndefined(isolate)) { data->GetIndexedPropertyHandler().IsUndefined(isolate)) {
function_type = FLAG_embedder_instance_types && data->HasInstanceType() function_type = v8_flags.embedder_instance_types && data->HasInstanceType()
? static_cast<InstanceType>(data->InstanceType()) ? static_cast<InstanceType>(data->InstanceType())
: JS_API_OBJECT_TYPE; : JS_API_OBJECT_TYPE;
} }

57
src/api/api.cc
View File

@ -284,7 +284,7 @@ void i::V8::FatalProcessOutOfMemory(i::Isolate* i_isolate, const char* location,
// BUG(1718): Don't use the take_snapshot since we don't support // BUG(1718): Don't use the take_snapshot since we don't support
// HeapObjectIterator here without doing a special GC. // HeapObjectIterator here without doing a special GC.
i_isolate->heap()->RecordStats(&heap_stats, false); i_isolate->heap()->RecordStats(&heap_stats, false);
if (!FLAG_correctness_fuzzer_suppressions) { if (!v8_flags.correctness_fuzzer_suppressions) {
char* first_newline = strchr(last_few_messages, '\n'); char* first_newline = strchr(last_few_messages, '\n');
if (first_newline == nullptr || first_newline[1] == '\0') if (first_newline == nullptr || first_newline[1] == '\0')
first_newline = last_few_messages; first_newline = last_few_messages;
@ -795,7 +795,7 @@ i::Address* GlobalizeTracedReference(i::Isolate* i_isolate, i::Address* obj,
i::Handle<i::Object> result = i::Handle<i::Object> result =
i_isolate->global_handles()->CreateTraced(*obj, slot, store_mode); i_isolate->global_handles()->CreateTraced(*obj, slot, store_mode);
#ifdef VERIFY_HEAP #ifdef VERIFY_HEAP
if (i::FLAG_verify_heap) { if (i::v8_flags.verify_heap) {
i::Object(*obj).ObjectVerify(i_isolate); i::Object(*obj).ObjectVerify(i_isolate);
} }
#endif // VERIFY_HEAP #endif // VERIFY_HEAP
@ -823,7 +823,7 @@ i::Address* GlobalizeReference(i::Isolate* i_isolate, i::Address* obj) {
API_RCS_SCOPE(i_isolate, Persistent, New); API_RCS_SCOPE(i_isolate, Persistent, New);
i::Handle<i::Object> result = i_isolate->global_handles()->Create(*obj); i::Handle<i::Object> result = i_isolate->global_handles()->Create(*obj);
#ifdef VERIFY_HEAP #ifdef VERIFY_HEAP
if (i::FLAG_verify_heap) { if (i::v8_flags.verify_heap) {
i::Object(*obj).ObjectVerify(i_isolate); i::Object(*obj).ObjectVerify(i_isolate);
} }
#endif // VERIFY_HEAP #endif // VERIFY_HEAP
@ -1676,7 +1676,7 @@ void ObjectTemplate::SetAccessor(v8::Local<String> name,
SideEffectType getter_side_effect_type, SideEffectType getter_side_effect_type,
SideEffectType setter_side_effect_type) { SideEffectType setter_side_effect_type) {
TemplateSetAccessor(this, name, getter, setter, data, settings, attribute, TemplateSetAccessor(this, name, getter, setter, data, settings, attribute,
i::FLAG_disable_old_api_accessors, false, i::v8_flags.disable_old_api_accessors, false,
getter_side_effect_type, setter_side_effect_type); getter_side_effect_type, setter_side_effect_type);
} }
@ -1688,7 +1688,7 @@ void ObjectTemplate::SetAccessor(v8::Local<Name> name,
SideEffectType getter_side_effect_type, SideEffectType getter_side_effect_type,
SideEffectType setter_side_effect_type) { SideEffectType setter_side_effect_type) {
TemplateSetAccessor(this, name, getter, setter, data, settings, attribute, TemplateSetAccessor(this, name, getter, setter, data, settings, attribute,
i::FLAG_disable_old_api_accessors, false, i::v8_flags.disable_old_api_accessors, false,
getter_side_effect_type, setter_side_effect_type); getter_side_effect_type, setter_side_effect_type);
} }
@ -2072,7 +2072,7 @@ MaybeLocal<Value> Script::Run(Local<Context> context,
// //
// To avoid this, on running scripts check first if JIT code log is // To avoid this, on running scripts check first if JIT code log is
// pending and generate immediately. // pending and generate immediately.
if (i::FLAG_enable_etw_stack_walking) { if (i::v8_flags.enable_etw_stack_walking) {
i::ETWJITInterface::MaybeSetHandlerNow(i_isolate); i::ETWJITInterface::MaybeSetHandlerNow(i_isolate);
} }
#endif #endif
@ -2081,14 +2081,15 @@ MaybeLocal<Value> Script::Run(Local<Context> context,
// TODO(crbug.com/1193459): remove once ablation study is completed // TODO(crbug.com/1193459): remove once ablation study is completed
base::ElapsedTimer timer; base::ElapsedTimer timer;
base::TimeDelta delta; base::TimeDelta delta;
if (i::FLAG_script_delay > 0) { if (i::v8_flags.script_delay > 0) {
delta = v8::base::TimeDelta::FromMillisecondsD(i::FLAG_script_delay); delta = v8::base::TimeDelta::FromMillisecondsD(i::v8_flags.script_delay);
} }
if (i::FLAG_script_delay_once > 0 && !i_isolate->did_run_script_delay()) { if (i::v8_flags.script_delay_once > 0 && !i_isolate->did_run_script_delay()) {
delta = v8::base::TimeDelta::FromMillisecondsD(i::FLAG_script_delay_once); delta =
v8::base::TimeDelta::FromMillisecondsD(i::v8_flags.script_delay_once);
i_isolate->set_did_run_script_delay(true); i_isolate->set_did_run_script_delay(true);
} }
if (i::FLAG_script_delay_fraction > 0.0) { if (i::v8_flags.script_delay_fraction > 0.0) {
timer.Start(); timer.Start();
} else if (delta.InMicroseconds() > 0) { } else if (delta.InMicroseconds() > 0) {
timer.Start(); timer.Start();
@ -2097,7 +2098,7 @@ MaybeLocal<Value> Script::Run(Local<Context> context,
} }
} }
if (V8_UNLIKELY(i::FLAG_experimental_web_snapshots)) { if (V8_UNLIKELY(i::v8_flags.experimental_web_snapshots)) {
i::Handle<i::HeapObject> maybe_script = i::Handle<i::HeapObject> maybe_script =
handle(fun->shared().script(), i_isolate); handle(fun->shared().script(), i_isolate);
if (maybe_script->IsScript() && if (maybe_script->IsScript() &&
@ -2121,9 +2122,9 @@ MaybeLocal<Value> Script::Run(Local<Context> context,
has_pending_exception = !ToLocal<Value>( has_pending_exception = !ToLocal<Value>(
i::Execution::CallScript(i_isolate, fun, receiver, options), &result); i::Execution::CallScript(i_isolate, fun, receiver, options), &result);
if (i::FLAG_script_delay_fraction > 0.0) { if (i::v8_flags.script_delay_fraction > 0.0) {
delta = v8::base::TimeDelta::FromMillisecondsD( delta = v8::base::TimeDelta::FromMillisecondsD(
timer.Elapsed().InMillisecondsF() * i::FLAG_script_delay_fraction); timer.Elapsed().InMillisecondsF() * i::v8_flags.script_delay_fraction);
timer.Restart(); timer.Restart();
while (timer.Elapsed() < delta) { while (timer.Elapsed() < delta) {
// Busy wait. // Busy wait.
@ -2714,7 +2715,7 @@ ScriptCompiler::ScriptStreamingTask* ScriptCompiler::StartStreaming(
Utils::ApiCheck(options == kNoCompileOptions || options == kEagerCompile, Utils::ApiCheck(options == kNoCompileOptions || options == kEagerCompile,
"v8::ScriptCompiler::StartStreaming", "v8::ScriptCompiler::StartStreaming",
"Invalid CompileOptions"); "Invalid CompileOptions");
if (!i::FLAG_script_streaming) return nullptr; if (!i::v8_flags.script_streaming) return nullptr;
i::Isolate* i_isolate = reinterpret_cast<i::Isolate*>(v8_isolate); i::Isolate* i_isolate = reinterpret_cast<i::Isolate*>(v8_isolate);
i::ScriptStreamingData* data = source->impl(); i::ScriptStreamingData* data = source->impl();
std::unique_ptr<i::BackgroundCompileTask> task = std::unique_ptr<i::BackgroundCompileTask> task =
@ -2747,20 +2748,22 @@ void ScriptCompiler::ConsumeCodeCacheTask::SourceTextAvailable(
bool ScriptCompiler::ConsumeCodeCacheTask::ShouldMergeWithExistingScript() bool ScriptCompiler::ConsumeCodeCacheTask::ShouldMergeWithExistingScript()
const { const {
if (!i::FLAG_merge_background_deserialized_script_with_compilation_cache) { if (!i::v8_flags
.merge_background_deserialized_script_with_compilation_cache) {
return false; return false;
} }
return impl_->ShouldMergeWithExistingScript(); return impl_->ShouldMergeWithExistingScript();
} }
void ScriptCompiler::ConsumeCodeCacheTask::MergeWithExistingScript() { void ScriptCompiler::ConsumeCodeCacheTask::MergeWithExistingScript() {
DCHECK(i::FLAG_merge_background_deserialized_script_with_compilation_cache); DCHECK(
i::v8_flags.merge_background_deserialized_script_with_compilation_cache);
impl_->MergeWithExistingScript(); impl_->MergeWithExistingScript();
} }
ScriptCompiler::ConsumeCodeCacheTask* ScriptCompiler::StartConsumingCodeCache( ScriptCompiler::ConsumeCodeCacheTask* ScriptCompiler::StartConsumingCodeCache(
Isolate* v8_isolate, std::unique_ptr<CachedData> cached_data) { Isolate* v8_isolate, std::unique_ptr<CachedData> cached_data) {
if (!i::FLAG_concurrent_cache_deserialization) return nullptr; if (!i::v8_flags.concurrent_cache_deserialization) return nullptr;
i::Isolate* i_isolate = reinterpret_cast<i::Isolate*>(v8_isolate); i::Isolate* i_isolate = reinterpret_cast<i::Isolate*>(v8_isolate);
DCHECK_NO_SCRIPT_NO_EXCEPTION(i_isolate); DCHECK_NO_SCRIPT_NO_EXCEPTION(i_isolate);
return new ScriptCompiler::ConsumeCodeCacheTask( return new ScriptCompiler::ConsumeCodeCacheTask(
@ -4895,7 +4898,7 @@ Maybe<bool> Object::SetAccessor(Local<Context> context, Local<Name> name,
SideEffectType setter_side_effect_type) { SideEffectType setter_side_effect_type) {
return ObjectSetAccessor(context, this, name, getter, setter, return ObjectSetAccessor(context, this, name, getter, setter,
data.FromMaybe(Local<Value>()), settings, attribute, data.FromMaybe(Local<Value>()), settings, attribute,
i::FLAG_disable_old_api_accessors, false, i::v8_flags.disable_old_api_accessors, false,
getter_side_effect_type, setter_side_effect_type); getter_side_effect_type, setter_side_effect_type);
} }
@ -8214,7 +8217,7 @@ static_assert(
Local<Type##Array> Type##Array::New( \ Local<Type##Array> Type##Array::New( \
Local<SharedArrayBuffer> shared_array_buffer, size_t byte_offset, \ Local<SharedArrayBuffer> shared_array_buffer, size_t byte_offset, \
size_t length) { \ size_t length) { \
CHECK(i::FLAG_harmony_sharedarraybuffer); \ CHECK(i::v8_flags.harmony_sharedarraybuffer); \
i::Isolate* i_isolate = \ i::Isolate* i_isolate = \
Utils::OpenHandle(*shared_array_buffer)->GetIsolate(); \ Utils::OpenHandle(*shared_array_buffer)->GetIsolate(); \
API_RCS_SCOPE(i_isolate, Type##Array, New); \ API_RCS_SCOPE(i_isolate, Type##Array, New); \
@ -8249,7 +8252,7 @@ Local<DataView> DataView::New(Local<ArrayBuffer> array_buffer,
Local<DataView> DataView::New(Local<SharedArrayBuffer> shared_array_buffer, Local<DataView> DataView::New(Local<SharedArrayBuffer> shared_array_buffer,
size_t byte_offset, size_t byte_length) { size_t byte_offset, size_t byte_length) {
CHECK(i::FLAG_harmony_sharedarraybuffer); CHECK(i::v8_flags.harmony_sharedarraybuffer);
i::Handle<i::JSArrayBuffer> buffer = Utils::OpenHandle(*shared_array_buffer); i::Handle<i::JSArrayBuffer> buffer = Utils::OpenHandle(*shared_array_buffer);
i::Isolate* i_isolate = buffer->GetIsolate(); i::Isolate* i_isolate = buffer->GetIsolate();
API_RCS_SCOPE(i_isolate, DataView, New); API_RCS_SCOPE(i_isolate, DataView, New);
@ -8266,7 +8269,7 @@ size_t v8::SharedArrayBuffer::ByteLength() const {
Local<SharedArrayBuffer> v8::SharedArrayBuffer::New(Isolate* v8_isolate, Local<SharedArrayBuffer> v8::SharedArrayBuffer::New(Isolate* v8_isolate,
size_t byte_length) { size_t byte_length) {
CHECK(i::FLAG_harmony_sharedarraybuffer); CHECK(i::v8_flags.harmony_sharedarraybuffer);
i::Isolate* i_isolate = reinterpret_cast<i::Isolate*>(v8_isolate); i::Isolate* i_isolate = reinterpret_cast<i::Isolate*>(v8_isolate);
API_RCS_SCOPE(i_isolate, SharedArrayBuffer, New); API_RCS_SCOPE(i_isolate, SharedArrayBuffer, New);
ENTER_V8_NO_SCRIPT_NO_EXCEPTION(i_isolate); ENTER_V8_NO_SCRIPT_NO_EXCEPTION(i_isolate);
@ -8288,7 +8291,7 @@ Local<SharedArrayBuffer> v8::SharedArrayBuffer::New(Isolate* v8_isolate,
Local<SharedArrayBuffer> v8::SharedArrayBuffer::New( Local<SharedArrayBuffer> v8::SharedArrayBuffer::New(
Isolate* v8_isolate, std::shared_ptr<BackingStore> backing_store) { Isolate* v8_isolate, std::shared_ptr<BackingStore> backing_store) {
CHECK(i::FLAG_harmony_sharedarraybuffer); CHECK(i::v8_flags.harmony_sharedarraybuffer);
CHECK_IMPLIES(backing_store->ByteLength() != 0, CHECK_IMPLIES(backing_store->ByteLength() != 0,
backing_store->Data() != nullptr); backing_store->Data() != nullptr);
i::Isolate* i_isolate = reinterpret_cast<i::Isolate*>(v8_isolate); i::Isolate* i_isolate = reinterpret_cast<i::Isolate*>(v8_isolate);
@ -8679,7 +8682,7 @@ bool Isolate::HasPendingBackgroundTasks() {
} }
void Isolate::RequestGarbageCollectionForTesting(GarbageCollectionType type) { void Isolate::RequestGarbageCollectionForTesting(GarbageCollectionType type) {
Utils::ApiCheck(i::FLAG_expose_gc, Utils::ApiCheck(i::v8_flags.expose_gc,
"v8::Isolate::RequestGarbageCollectionForTesting", "v8::Isolate::RequestGarbageCollectionForTesting",
"Must use --expose-gc"); "Must use --expose-gc");
if (type == kMinorGarbageCollection) { if (type == kMinorGarbageCollection) {
@ -9195,7 +9198,7 @@ int64_t Isolate::AdjustAmountOfExternalAllocatedMemory(
void Isolate::SetEventLogger(LogEventCallback that) { void Isolate::SetEventLogger(LogEventCallback that) {
// Do not overwrite the event logger if we want to log explicitly. // Do not overwrite the event logger if we want to log explicitly.
if (i::FLAG_log_internal_timer_events) return; if (i::v8_flags.log_internal_timer_events) return;
i::Isolate* i_isolate = reinterpret_cast<i::Isolate*>(this); i::Isolate* i_isolate = reinterpret_cast<i::Isolate*>(this);
i_isolate->set_event_logger(that); i_isolate->set_event_logger(that);
} }
@ -9328,7 +9331,7 @@ bool Isolate::IdleNotificationDeadline(double deadline_in_seconds) {
// Returning true tells the caller that it need not // Returning true tells the caller that it need not
// continue to call IdleNotification. // continue to call IdleNotification.
i::Isolate* i_isolate = reinterpret_cast<i::Isolate*>(this); i::Isolate* i_isolate = reinterpret_cast<i::Isolate*>(this);
if (!i::FLAG_use_idle_notification) return true; if (!i::v8_flags.use_idle_notification) return true;
return i_isolate->heap()->IdleNotification(deadline_in_seconds); return i_isolate->heap()->IdleNotification(deadline_in_seconds);
} }
@ -9531,7 +9534,7 @@ void Isolate::InstallConditionalFeatures(Local<Context> context) {
if (i_isolate->is_execution_terminating()) return; if (i_isolate->is_execution_terminating()) return;
i_isolate->InstallConditionalFeatures(Utils::OpenHandle(*context)); i_isolate->InstallConditionalFeatures(Utils::OpenHandle(*context));
#if V8_ENABLE_WEBASSEMBLY #if V8_ENABLE_WEBASSEMBLY
if (i::FLAG_expose_wasm && !i_isolate->has_pending_exception()) { if (i::v8_flags.expose_wasm && !i_isolate->has_pending_exception()) {
i::WasmJs::InstallConditionalFeatures(i_isolate, i::WasmJs::InstallConditionalFeatures(i_isolate,
Utils::OpenHandle(*context)); Utils::OpenHandle(*context));
} }