AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[map] Faster HasOutOfObjectProperties check

Browse Source 
The used_or_unused_instance_size_in_words field already determines
whether the used fields are in- or out-of-object, so we can use it's
value for a fast HasOutOfObjectProperties check rather than using
NumberOfFields (which includes an iteration over the descriptor
array).

Change-Id: I6c5b4f3f793b8df7832def7465106f2af7306759
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1718152
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Igor Sheludko <ishell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#81828}
This commit is contained in:
Leszek Swirski 2022-07-15 15:16:07 +02:00 committed by V8 LUCI CQ
parent 9981f2e592
commit 49c31ec156
3 changed files with 9 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/objects/map-inl.h
View File

@ -313,6 +313,13 @@ void Map::SetInObjectPropertiesStartInWords(int value) {
set_inobject_properties_start_or_constructor_function_index(value); set_inobject_properties_start_or_constructor_function_index(value);
} }
bool Map::HasOutOfObjectProperties() const {
bool ret = used_or_unused_instance_size_in_words() < JSObject::kFieldsAdded;
DCHECK_EQ(ret, GetInObjectProperties() <
NumberOfFields(ConcurrencyMode::kSynchronous));
return ret;
}
int Map::GetInObjectProperties() const { int Map::GetInObjectProperties() const {
DCHECK(IsJSObjectMap()); DCHECK(IsJSObjectMap());
return instance_size_in_words() - GetInObjectPropertiesStartInWords(); return instance_size_in_words() - GetInObjectPropertiesStartInWords();

5
src/objects/map.cc
View File

@ -571,11 +571,6 @@ Map::FieldCounts Map::GetFieldCounts() const {
return FieldCounts(mutable_count, const_count); return FieldCounts(mutable_count, const_count);
} }
bool Map::HasOutOfObjectProperties() const {
return GetInObjectProperties() <
NumberOfFields(ConcurrencyMode::kSynchronous);
}
void Map::DeprecateTransitionTree(Isolate* isolate) { void Map::DeprecateTransitionTree(Isolate* isolate) {
if (is_deprecated()) return; if (is_deprecated()) return;
TransitionsAccessor transitions(isolate, *this); TransitionsAccessor transitions(isolate, *this);

4
src/objects/map.h
View File

@ -240,6 +240,8 @@ class Map : public TorqueGeneratedMap<Map, HeapObject> {
// is equal to the instance size). // is equal to the instance size).
inline int UsedInstanceSize() const; inline int UsedInstanceSize() const;
inline bool HasOutOfObjectProperties() const;
// Tells how many unused property fields (in-object or out-of object) are // Tells how many unused property fields (in-object or out-of object) are
// available in the instance (only used for JSObject in fast mode). // available in the instance (only used for JSObject in fast mode).
inline int UnusedPropertyFields() const; inline int UnusedPropertyFields() const;
@ -505,8 +507,6 @@ class Map : public TorqueGeneratedMap<Map, HeapObject> {
FieldCounts GetFieldCounts() const; FieldCounts GetFieldCounts() const;
int NumberOfFields(ConcurrencyMode cmode) const; int NumberOfFields(ConcurrencyMode cmode) const;
bool HasOutOfObjectProperties() const;
// TODO(ishell): candidate with JSObject::MigrateToMap(). // TODO(ishell): candidate with JSObject::MigrateToMap().
bool InstancesNeedRewriting(Map target, ConcurrencyMode cmode) const; bool InstancesNeedRewriting(Map target, ConcurrencyMode cmode) const;
bool InstancesNeedRewriting(Map target, int target_number_of_fields, bool InstancesNeedRewriting(Map target, int target_number_of_fields,