From 49c4718443997269c151bb14deed860176bd5ce3 Mon Sep 17 00:00:00 2001 From: "lrn@chromium.org" Date: Fri, 25 Jun 2010 12:31:49 +0000 Subject: [PATCH] Fix bug in CheckBothPositiveSmi macro. Fix lint. Review URL: http://codereview.chromium.org/2826021 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4952 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- src/ia32/codegen-ia32.cc | 1 - src/x64/macro-assembler-x64.cc | 4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/ia32/codegen-ia32.cc b/src/ia32/codegen-ia32.cc index bd2926f1cf..c0c54426a3 100644 --- a/src/ia32/codegen-ia32.cc +++ b/src/ia32/codegen-ia32.cc @@ -13410,7 +13410,6 @@ void SubStringStub::Generate(MacroAssembler* masm) { // Just jump to runtime to create the sub string. __ bind(&runtime); __ TailCallRuntime(Runtime::kSubString, 3, 1); - } diff --git a/src/x64/macro-assembler-x64.cc b/src/x64/macro-assembler-x64.cc index 0259054e44..32cd2dbc13 100644 --- a/src/x64/macro-assembler-x64.cc +++ b/src/x64/macro-assembler-x64.cc @@ -652,8 +652,8 @@ Condition MacroAssembler::CheckBothPositiveSmi(Register first, if (first.is(second)) { return CheckPositiveSmi(first); } - movl(kScratchRegister, first); - orl(kScratchRegister, second); + movq(kScratchRegister, first); + or_(kScratchRegister, second); rol(kScratchRegister, Immediate(1)); testl(kScratchRegister, Immediate(0x03)); return zero;