AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Remove last LookupOwnRealNamedProperty usage from runtime.cc

Browse Source 
BUG=
R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/494663002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23261 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
verwaest@chromium.org 2014-08-21 08:19:05 +00:00
parent e4c3c439af
commit 49e4aebb98
2 changed files with 5 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/property.h
View File

@ -252,8 +252,7 @@ class LookupResult V8_FINAL BASE_EMBEDDED {
} }
bool IsNormal() const { bool IsNormal() const {
DCHECK(!(details_.type() == NORMAL && !IsFound())); return IsFound() && IsDescriptorOrDictionary() && type() == NORMAL;
return IsDescriptorOrDictionary() && type() == NORMAL;
} }
bool IsConstant() const { bool IsConstant() const {

11
src/runtime.cc
View File

@ -5027,15 +5027,12 @@ RUNTIME_FUNCTION(Runtime_DefineDataPropertyUnchecked) {
return isolate->heap()->undefined_value(); return isolate->heap()->undefined_value();
} }
LookupResult lookup(isolate); LookupIterator it(js_object, name, LookupIterator::CHECK_PROPERTY);
js_object->LookupOwnRealNamedProperty(name, &lookup);
// Take special care when attributes are different and there is already // Take special care when attributes are different and there is already
// a property. For simplicity we normalize the property which enables us // a property.
// to not worry about changing the instance_descriptor and creating a new if (it.IsFound() && it.HasProperty() &&
// map. it.property_kind() == LookupIterator::ACCESSOR) {
if (lookup.IsFound() &&
(attr != lookup.GetAttributes() || lookup.IsPropertyCallbacks())) {
// Use IgnoreAttributes version since a readonly property may be // Use IgnoreAttributes version since a readonly property may be
// overridden and SetProperty does not allow this. // overridden and SetProperty does not allow this.
Handle<Object> result; Handle<Object> result;