AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[debugger] Simplify deletion of DeoptimizedFrameInfo.

Browse Source 
R=yangguo@chromium.org,jarin@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2112443002
Cr-Commit-Position: refs/heads/master@{#37377}
This commit is contained in:
titzer 2016-06-29 02:42:53 -07:00 committed by Commit bot
parent 46a365faae
commit 4a8ac723ae
3 changed files with 2 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/debug/debug-frames.cc
View File

@ -31,15 +31,13 @@ FrameInspector::FrameInspector(JavaScriptFrame* frame,
} }
} }
FrameInspector::~FrameInspector() { FrameInspector::~FrameInspector() {
// Get rid of the calculated deoptimized frame if any. // Get rid of the calculated deoptimized frame if any.
if (deoptimized_frame_ != NULL) { if (deoptimized_frame_ != nullptr) {
Deoptimizer::DeleteDebuggerInspectableFrame(deoptimized_frame_, isolate_); delete deoptimized_frame_;
} }
} }
int FrameInspector::GetParametersCount() { int FrameInspector::GetParametersCount() {
return is_optimized_ ? deoptimized_frame_->parameters_count() return is_optimized_ ? deoptimized_frame_->parameters_count()
: frame_->ComputeParametersCount(); : frame_->ComputeParametersCount();

8
src/deoptimizer.cc
View File

@ -159,13 +159,6 @@ DeoptimizedFrameInfo* Deoptimizer::DebuggerInspectableFrame(
return info; return info;
} }
void Deoptimizer::DeleteDebuggerInspectableFrame(DeoptimizedFrameInfo* info,
Isolate* isolate) {
delete info;
}
void Deoptimizer::GenerateDeoptimizationEntries(MacroAssembler* masm, void Deoptimizer::GenerateDeoptimizationEntries(MacroAssembler* masm,
int count, int count,
BailoutType type) { BailoutType type) {
@ -173,7 +166,6 @@ void Deoptimizer::GenerateDeoptimizationEntries(MacroAssembler* masm,
generator.Generate(); generator.Generate();
} }
void Deoptimizer::VisitAllOptimizedFunctionsForContext( void Deoptimizer::VisitAllOptimizedFunctionsForContext(
Context* context, OptimizedFunctionVisitor* visitor) { Context* context, OptimizedFunctionVisitor* visitor) {
DisallowHeapAllocation no_allocation; DisallowHeapAllocation no_allocation;

2
src/deoptimizer.h
View File

@ -493,8 +493,6 @@ class Deoptimizer : public Malloced {
static DeoptimizedFrameInfo* DebuggerInspectableFrame(JavaScriptFrame* frame, static DeoptimizedFrameInfo* DebuggerInspectableFrame(JavaScriptFrame* frame,
int jsframe_index, int jsframe_index,
Isolate* isolate); Isolate* isolate);
static void DeleteDebuggerInspectableFrame(DeoptimizedFrameInfo* info,
Isolate* isolate);
// Makes sure that there is enough room in the relocation // Makes sure that there is enough room in the relocation
// information of a code object to perform lazy deoptimization // information of a code object to perform lazy deoptimization