AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Fixed space leak in DebuggerAgentSession.

Browse Source 
Ownership in this part is still very convoluted and should probably be
cleaned up, this is only the minimal CL needed to fix the leak.

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/153623009

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19148 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
svenpanne@chromium.org 2014-02-06 12:09:08 +00:00
parent e6bc60c98d
commit 4ab3270dd5
2 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/debug-agent.cc
View File

@ -173,6 +173,11 @@ void DebuggerAgent::DebuggerMessage(const v8::Debug::Message& message) {
} }
DebuggerAgentSession::~DebuggerAgentSession() {
delete client_;
}
void DebuggerAgent::OnSessionClosed(DebuggerAgentSession* session) { void DebuggerAgent::OnSessionClosed(DebuggerAgentSession* session) {
// Don't do anything during termination. // Don't do anything during termination.
if (terminate_) { if (terminate_) {

1
src/debug-agent.h
View File

@ -83,6 +83,7 @@ class DebuggerAgentSession: public Thread {
DebuggerAgentSession(DebuggerAgent* agent, Socket* client) DebuggerAgentSession(DebuggerAgent* agent, Socket* client)
: Thread("v8:DbgAgntSessn"), : Thread("v8:DbgAgntSessn"),
agent_(agent), client_(client) {} agent_(agent), client_(client) {}
~DebuggerAgentSession();
void DebuggerMessage(Vector<uint16_t> message); void DebuggerMessage(Vector<uint16_t> message);
void Shutdown(); void Shutdown();