From 4adfb5669e462e10343224b61535ee7886673c9b Mon Sep 17 00:00:00 2001 From: Clemens Backes Date: Mon, 4 Oct 2021 15:16:05 +0000 Subject: [PATCH] Revert "Turn on v8_enable_virtual_memory_cage for Chromium builds" MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This reverts commit 4fb3eae7afa2023057818d11faeefc031b78d444. Reason for revert: Fails to link on chromium, blocking the roll: https://cr-buildbucket.appspot.com/build/8834293599516974577 Original change's description: > Turn on v8_enable_virtual_memory_cage for Chromium builds > > This CL enables the virtual memory cage at compile time by default for > Chromium builds on x64 and arm64. However, the cage will only be used at > runtime if the correpsonding Chromium feature is enabled as well. > > Bug: chromium:1218005 > Change-Id: I5a452d299ac950f8ec0f741f6b9a153e57b2a666 > Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3200081 > Reviewed-by: Toon Verwaest > Commit-Queue: Samuel Groß > Cr-Commit-Position: refs/heads/main@{#77212} Bug: chromium:1218005 Change-Id: Id17946641b7b4e0d377d4e211aab929bb39ec341 Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3201998 Auto-Submit: Clemens Backes Commit-Queue: Rubber Stamper Bot-Commit: Rubber Stamper Cr-Commit-Position: refs/heads/main@{#77220} --- BUILD.gn | 7 ------- 1 file changed, 7 deletions(-) diff --git a/BUILD.gn b/BUILD.gn index 6349281e31..c38572d6bf 100644 --- a/BUILD.gn +++ b/BUILD.gn @@ -472,13 +472,6 @@ if (build_with_chromium && v8_current_cpu == "arm64" && v8_control_flow_integrity = true } -# Enable the virtual memory cage on 64-bit Chromium builds. -if (build_with_chromium && - (v8_current_cpu == "arm64" || v8_current_cpu == "x64")) { - # The cage is incompatible with lsan. - v8_enable_virtual_memory_cage = !is_lsan -} - assert(!v8_disable_write_barriers || v8_enable_single_generation, "Disabling write barriers works only with single generation")