AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[d8] Print --experimental message earlier in d8.cc

Browse Source 
Previously, we printed the message in RunShell, which meant that it was
only visible if d8 was running in interactive mode. Now we print it
earlier so that the message is also printed when d8 executes a .js file.

Change-Id: Icdadbe5eee7400aaa843b747e3374bda41e360b8
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4224014
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Samuel Groß <saelo@chromium.org>
Cr-Commit-Position: refs/heads/main@{#85666}
This commit is contained in:
Samuel Groß 2023-02-06 10:18:06 +01:00 committed by V8 LUCI CQ
parent a2f63f1886
commit 4ae2bea49f
1 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/d8/d8.cc
View File

@ -4014,13 +4014,6 @@ void Shell::RunShell(Isolate* isolate) {
PerIsolateData::RealmScope realm_scope(PerIsolateData::Get(isolate));
Local<String> name = String::NewFromUtf8Literal(isolate, "(d8)");
printf("V8 version %s\n", V8::GetVersion());
if (i::v8_flags.experimental) {
// This message is printed to stderr so that it is also visible in
// Clusterfuzz reports.
fprintf(stderr,
"V8 is running with experimental features enabled. Stability and "
"security will suffer.\n");
}
while (true) {
HandleScope inner_scope(isolate);
printf("d8> ");
@ -5693,6 +5686,14 @@ int Shell::Main(int argc, char* argv[]) {
}
#endif // V8_ENABLE_WEBASSEMBLY
if (i::v8_flags.experimental) {
// This message is printed to stderr so that it is also visible in
// Clusterfuzz reports.
fprintf(stderr,
"V8 is running with experimental features enabled. Stability and "
"security will suffer.\n");
}
Isolate* isolate = Isolate::New(create_params);
#ifdef V8_FUZZILLI