AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Added check for logging enabled in two places where processing/allocation was performed only to be used only as parameters for the LOG macro. Looked through all the uses of the LOG macro and found only these two places where additional checking was required.

Browse Source 
Fixed a couple of comments looking through all the uses of the LOG macro.
Review URL: http://codereview.chromium.org/20018

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1220 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
sgjesse@chromium.org 2009-02-03 14:44:39 +00:00
parent 78ec586391
commit 4b05db4ee0
2 changed files with 27 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
src/compiler.cc
View File

@ -121,13 +121,19 @@ static Handle<JSFunction> MakeFunction(bool is_global,
return Handle<JSFunction>::null();
}
if (script->name()->IsString()) {
SmartPointer<char> data =
String::cast(script->name())->ToCString(DISALLOW_NULLS);
LOG(CodeCreateEvent(is_eval ? "Eval" : "Script", *code, *data));
} else {
LOG(CodeCreateEvent(is_eval ? "Eval" : "Script", *code, ""));
#ifdef ENABLE_LOGGING_AND_PROFILING
// Log the code generation for the script. Check explicit whether logging is
// to avoid allocating when not required.
if (Logger::is_enabled()) {
if (script->name()->IsString()) {
SmartPointer<char> data =
String::cast(script->name())->ToCString(DISALLOW_NULLS);
LOG(CodeCreateEvent(is_eval ? "Eval" : "Script", *code, *data));
} else {
LOG(CodeCreateEvent(is_eval ? "Eval" : "Script", *code, ""));
}
}
#endif
// Allocate function.
Handle<JSFunction> fun =
@ -292,17 +298,21 @@ bool Compiler::CompileLazy(Handle<SharedFunctionInfo> shared,
return false;
}
// Generate the code, update the function info, and return the code.
#ifdef ENABLE_LOGGING_AND_PROFILING
if (script->name()->IsString()) {
int lineNum = script->GetLineNumber(start_position);
if (lineNum > 0) {
lineNum += script->line_offset()->value() + 1;
// Log the code generation. If source information is available include script
// name and line number. Check explicit whether logging is enabled as finding
// the line number is not for free.
if (Logger::is_enabled()) {
if (script->name()->IsString()) {
int lineNum = script->GetLineNumber(start_position);
if (lineNum > 0) {
lineNum += script->line_offset()->value() + 1;
}
LOG(CodeCreateEvent("LazyCompile", *code, *lit->name(),
String::cast(script->name()), lineNum));
} else {
LOG(CodeCreateEvent("LazyCompile", *code, *lit->name()));
}
LOG(CodeCreateEvent("LazyCompile", *code, *lit->name(),
String::cast(script->name()), lineNum));
} else {
LOG(CodeCreateEvent("LazyCompile", *code, *lit->name()));
}
#endif

3
src/mark-compact.cc
View File

@ -1111,6 +1111,7 @@ static void SweepSpace(PagedSpace* space, DeallocateFunction dealloc) {
}
} else {
if (object->IsCode()) {
// Notify the logger that compiled code has been collected.
LOG(CodeDeleteEvent(Code::cast(object)->address()));
}
if (is_previous_alive) { // Transition from live to free.
@ -1678,7 +1679,7 @@ int MarkCompactCollector::RelocateCodeObject(HeapObject* obj) {
if (copied_to->IsCode()) {
// may also update inline cache target.
Code::cast(copied_to)->Relocate(new_addr - old_addr);
// Notify the logger that compile code has moved.
// Notify the logger that compiled code has moved.
LOG(CodeMoveEvent(old_addr, new_addr));
}