AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[wasm] Deprecate CPU timings in metrics

Browse Source 
We do not collect them any more since https://crrev.com/c/4078966
(landed in v11.0), so deprecate the fields now for v11.1.

R=mlippautz@chromium.org

Bug: v8:13565
Change-Id: I6b454cd6591c6489043002226f3c4fd19fdeb7e5
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4079227
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#84871}
This commit is contained in:
Clemens Backes 2022-12-06 14:52:18 +01:00 committed by V8 LUCI CQ
parent fffae64444
commit 4b451843fd
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
include/v8-metrics.h
View File

@ -108,7 +108,7 @@ struct WasmModuleDecoded {
function_count(function_count),
wall_clock_duration_in_us(wall_clock_duration_in_us) {}
V8_DEPRECATE_SOON("Use the version without cpu_duration_in_us")
V8_DEPRECATED("Use the version without cpu_duration_in_us")
WasmModuleDecoded(bool async, bool streamed, bool success,
size_t module_size_in_bytes, size_t function_count,
int64_t wall_clock_duration_in_us,
@ -134,7 +134,7 @@ struct WasmModuleDecoded {
size_t module_size_in_bytes = 0;
size_t function_count = 0;
int64_t wall_clock_duration_in_us = -1;
V8_DEPRECATE_SOON("We do not collect cpu times any more")
V8_DEPRECATED("We do not collect cpu times any more")
int64_t cpu_duration_in_us = -1;
};
@ -155,7 +155,7 @@ struct WasmModuleCompiled {
liftoff_bailout_count(liftoff_bailout_count),
wall_clock_duration_in_us(wall_clock_duration_in_us) {}
V8_DEPRECATE_SOON("Use the version without cpu_duration_in_us")
V8_DEPRECATED("Use the version without cpu_duration_in_us")
WasmModuleCompiled(bool async, bool streamed, bool cached, bool deserialized,
bool lazy, bool success, size_t code_size_in_bytes,
size_t liftoff_bailout_count,
@ -188,7 +188,7 @@ struct WasmModuleCompiled {
size_t code_size_in_bytes = 0;
size_t liftoff_bailout_count = 0;
int64_t wall_clock_duration_in_us = -1;
V8_DEPRECATE_SOON("We do not collect cpu times any more")
V8_DEPRECATED("We do not collect cpu times any more")
int64_t cpu_duration_in_us = -1;
};