AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Revert "[CFI] Refactor test use to use GeneratedCode"

Browse Source 
This reverts commit e5a687be00.

Reason for revert: Crashes on GCC: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20gcc%204.8/builds/19002

Original change's description:
> [CFI] Refactor test use to use GeneratedCode
> 
> Replace direct call to generated code with call using GeneratedCode to
> match the rest of v8.
> 
> BUG=v8:7164
> 
> Change-Id: I3e45d3e7c45f06fc362a22217ee7f0f1b70745e2
> Reviewed-on: https://chromium-review.googlesource.com/1002534
> Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
> Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#52536}

TBR=clemensh@chromium.org,vtsyrklevich@chromium.org

Change-Id: I684a93d20f104244e2b74ab79ddc7d6e3a1ecf3c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: v8:7164
Reviewed-on: https://chromium-review.googlesource.com/1006614
Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#52538}
This commit is contained in:
Clemens Hammacher 2018-04-11 08:49:20 +00:00 committed by Commit Bot
parent 9018bb1af4
commit 4b88239533
1 changed files with 1 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
test/cctest/test-code-stubs.cc
View File

@ -37,7 +37,6 @@
#include "src/heap/factory.h"
#include "src/macro-assembler.h"
#include "src/objects-inl.h"
#include "src/simulator.h"
#include "test/cctest/cctest.h"
#include "test/cctest/test-code-stubs.h"
@ -98,17 +97,7 @@ void RunOneTruncationTestWithTest(ConvertDToICallWrapper callWrapper,
int32_t DefaultCallWrapper(ConvertDToIFunc func,
double from) {
if (func == &ConvertDToICVersion) return (*func)(from);
#ifdef USE_SIMULATOR
// Simulator users will require a custom 'RunGeneratedCodeCallWrapper' to
// account for platform-specific floating point calling conventions.
UNREACHABLE();
#else
auto f =
GeneratedCode<int32_t(double)>::FromAddress(CcTest::i_isolate(), func);
return f.Call(from);
#endif
return (*func)(from);
}