From 4c7c7d1a24844fb7109cb3fb6443b33ac894e943 Mon Sep 17 00:00:00 2001 From: Reece Wilson Date: Sun, 16 Oct 2022 01:26:25 +0100 Subject: [PATCH] [*] Fixed MSVC cannot initialize CppHeapCreateParams with an initializer list. Furthermore, CppHeapCreateParams is improperly exported. Specifying visibility confuses MSVC. There are no implemented member symbols for visibility to make sense. --- include/v8-cppgc.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/include/v8-cppgc.h b/include/v8-cppgc.h index 0f18de2b12..8c7dc28b7e 100644 --- a/include/v8-cppgc.h +++ b/include/v8-cppgc.h @@ -76,12 +76,15 @@ struct WrapperDescriptor final { uint16_t embedder_id_for_garbage_collected; }; -struct V8_EXPORT CppHeapCreateParams { +struct CppHeapCreateParams { CppHeapCreateParams() = default; CppHeapCreateParams(const CppHeapCreateParams&) = delete; CppHeapCreateParams(CppHeapCreateParams&&) = default; CppHeapCreateParams &operator = (const CppHeapCreateParams&) = delete; + inline CppHeapCreateParams(WrapperDescriptor wrapper_descriptor) + : wrapper_descriptor(wrapper_descriptor) {} + std::vector> custom_spaces; WrapperDescriptor wrapper_descriptor; /**