[test] Reverse sense of wasm_traps variant

D8 enables the Wasm trap handler by default now, but we need to make sure the
older bounds check case still gets test coverage too, as bounds checks will
continue to be a supported configuration.

Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
Change-Id: I5b0bdded6929a9b3a8480e87d038398b8d2a0fd8
Reviewed-on: https://chromium-review.googlesource.com/1048835
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Eric Holk <eholk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53078}
This commit is contained in:
Eric Holk 2018-05-07 16:38:47 -07:00 committed by Commit Bot
parent 8751debc3f
commit 4d4a3294b9
10 changed files with 19 additions and 20 deletions

View File

@ -416,7 +416,7 @@
}], # variant == stress_incremental_marking
##############################################################################
['variant == wasm_traps', {
['variant == no_wasm_traps', {
'test-accessors/*': [SKIP],
'test-api-interceptors/*': [SKIP],
'test-api/*': [SKIP],
@ -438,6 +438,6 @@
'test-log/*': [SKIP],
'test-gap-resolver/*': [SKIP],
'test-dtoa/*': [SKIP],
}], # variant == wasm_traps
}], # variant == no_wasm_traps
]

View File

@ -75,9 +75,9 @@
}], # 'gc_stress == True'
##############################################################################
['variant == wasm_traps', {
['variant == no_wasm_traps', {
'*': [SKIP],
}], # variant == wasm_traps
}], # variant == no_wasm_traps
##############################################################################
['arch == arm and not simulator_run', {

View File

@ -20,8 +20,8 @@
}], # variant != default
##############################################################################
['variant == wasm_traps', {
['variant == no_wasm_traps', {
'*': [SKIP],
}], # variant == wasm_traps
}], # variant == no_wasm_traps
]

View File

@ -31,8 +31,8 @@
'overrides/caching': [PASS, FAIL],
}], # ALWAYS
['variant == wasm_traps', {
['variant == no_wasm_traps', {
'*': [SKIP],
}], # variant == wasm_traps
}], # variant == no_wasm_traps
]

View File

@ -788,7 +788,7 @@
}], # 'gcov_coverage'
##############################################################################
['variant == wasm_traps', {
['variant == no_wasm_traps', {
# Skip stuff uninteresting for wasm traps
'bugs/*': [SKIP],
'compiler/*': [SKIP],
@ -804,7 +804,7 @@
'math-*': [SKIP],
'unicode-test': [SKIP],
'whitespaces': [SKIP],
}], # variant == wasm_traps
}], # variant == no_wasm_traps
##############################################################################
['no_harness', {

View File

@ -1014,8 +1014,8 @@
'ecma_3/RegExp/regress-85721': [SKIP],
}], # tsan
['variant == wasm_traps', {
['variant == no_wasm_traps', {
'*': [SKIP],
}], # variant == wasm_traps
}], # variant == no_wasm_traps
]

View File

@ -619,9 +619,9 @@
'built-ins/SharedArrayBuffer/length-is-too-large-throws': [SKIP],
}], # asan == True or msan == True or tsan == True
['variant == wasm_traps', {
['variant == no_wasm_traps', {
'*': [SKIP],
}], # variant == wasm_traps
}], # variant == no_wasm_traps
['variant != default or arch == arm or arch == arm64 or arch == mipsel or arch == mips or arch == mips64 or arch == mips64el', {
# These tests take a long time to run

View File

@ -120,14 +120,14 @@
}], # 'gcov_coverage'
##############################################################################
['variant == wasm_traps', {
['variant == no_wasm_traps', {
'*': [SKIP],
}], # variant == wasm_traps
}], # variant == no_wasm_traps
##############################################################################
['no_i18n == True', {
'fast/js/string-capitalization': [FAIL],
}], # variant == wasm_traps
}], # variant == no_wasm_traps
##############################################################################
]

View File

@ -22,7 +22,7 @@ ALL_VARIANT_FLAGS = {
# Trigger stress sampling allocation profiler with sample interval = 2^14
"stress_sampling": [["--stress-sampling-allocation-profiler=16384"]],
"trusted": [["--no-untrusted-code-mitigations"]],
"wasm_traps": [["--wasm-trap-handler", "--invoke-weak-callbacks"]],
"no_wasm_traps": [["--no-wasm-trap-handler"]],
}
SLOW_VARIANTS = set([

View File

@ -33,7 +33,6 @@ MORE_VARIANTS = [
"stress",
"stress_background_compile",
"stress_incremental_marking",
"wasm_traps",
]
VARIANT_ALIASES = {
@ -44,7 +43,7 @@ VARIANT_ALIASES = {
# Shortcut for the two above ("more" first - it has the longer running tests).
"exhaustive": MORE_VARIANTS + VARIANTS,
# Additional variants, run on a subset of bots.
"extra": ["future", "liftoff", "trusted"],
"extra": ["future", "liftoff", "no_wasm_traps", "trusted"],
}
GC_STRESS_FLAGS = ["--gc-interval=500", "--stress-compaction",