AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

unified-young-gen: Change DCHECK in the remembered set visitor

Browse Source 
There are other wrapper types that may coalesce to the same visitor id.
The CL simply checks that the objects being visited have embedder
fields.

Bug: v8:13475
Change-Id: I098056e9cf720ac0d5c6b10495ccdca88df62ecf
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4061575
Auto-Submit: Anton Bikineev <bikineev@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#84548}
This commit is contained in:
Anton Bikineev 2022-11-29 15:32:27 +01:00 committed by V8 LUCI CQ
parent 1d415100ed
commit 4f2d5b3b77
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/heap/mark-compact.cc
View File

@ -560,8 +560,7 @@ bool MarkCompactCollector::StartCompaction(StartCompactionMode mode) {
namespace {
void VisitObjectWithEmbedderFields(JSObject object,
MarkingWorklists::Local& worklist) {
DCHECK(object.IsJSApiObject() || object.IsJSArrayBuffer() ||
object.IsJSDataView() || object.IsJSTypedArray());
DCHECK(object.MayHaveEmbedderFields());
DCHECK(!Heap::InYoungGeneration(object));
MarkingWorklists::Local::WrapperSnapshot wrapper_snapshot;