AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Reland of Fix compiler warnings on "make android_arm" (patchset #1 id:1 of https://codereview.chromium.org/2286163002/ )

Browse Source 
Reason for revert:
Roll was unstuck before the revert landed => reland

Original issue's description:
> Revert of Fix compiler warnings on "make android_arm" (patchset #1 id:1 of https://codereview.chromium.org/2264283007/ )
>
> Reason for revert:
> Speculative revert because of roll blocker https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20debug/builds/2241
>
> Original issue's description:
> > Fix compiler warnings on "make android_arm"
> >
> > Committed: https://crrev.com/3e809a6129d0097529c885579ac46e4acf4e99f6
> > Cr-Commit-Position: refs/heads/master@{#38937}
>
> TBR=bmeurer@chromium.org,jkummerow@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
>
> Committed: https://crrev.com/d992c1f52f116930239ed90cc033442047e789b4
> Cr-Commit-Position: refs/heads/master@{#38961}

TBR=bmeurer@chromium.org,jkummerow@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2285113002
Cr-Commit-Position: refs/heads/master@{#38962}
This commit is contained in:
hablich 2016-08-28 14:03:07 -07:00 committed by Commit bot
parent d992c1f52f
commit 4f8e0fa685
6 changed files with 11 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
gypfiles/standalone.gypi
View File

@ -378,6 +378,9 @@
'arm_version%': '<(arm_version)',
'host_os%': '<(host_os)',
# Print to stdout on Android.
'v8_android_log_stdout%': 1,
'conditions': [
['android_ndk_root==""', {
'variables': {

4
src/compiler/js-operator.cc
View File

@ -376,7 +376,7 @@ const CreateLiteralParameters& CreateLiteralParametersOf(const Operator* op) {
return OpParameter<CreateLiteralParameters>(op);
}
const BinaryOperationHint BinaryOperationHintOf(const Operator* op) {
BinaryOperationHint BinaryOperationHintOf(const Operator* op) {
DCHECK(op->opcode() == IrOpcode::kJSBitwiseOr ||
op->opcode() == IrOpcode::kJSBitwiseXor ||
op->opcode() == IrOpcode::kJSBitwiseAnd ||
@ -391,7 +391,7 @@ const BinaryOperationHint BinaryOperationHintOf(const Operator* op) {
return OpParameter<BinaryOperationHint>(op);
}
const CompareOperationHint CompareOperationHintOf(const Operator* op) {
CompareOperationHint CompareOperationHintOf(const Operator* op) {
DCHECK(op->opcode() == IrOpcode::kJSEqual ||
op->opcode() == IrOpcode::kJSNotEqual ||
op->opcode() == IrOpcode::kJSStrictEqual ||

4
src/compiler/js-operator.h
View File

@ -374,9 +374,9 @@ std::ostream& operator<<(std::ostream&, CreateLiteralParameters const&);
const CreateLiteralParameters& CreateLiteralParametersOf(const Operator* op);
const BinaryOperationHint BinaryOperationHintOf(const Operator* op);
BinaryOperationHint BinaryOperationHintOf(const Operator* op);
const CompareOperationHint CompareOperationHintOf(const Operator* op);
CompareOperationHint CompareOperationHintOf(const Operator* op);
// Interface for building JavaScript-level operators, e.g. directly from the
// AST. Most operators have no parameters, thus can be globally shared for all

2
src/deoptimize-reason.cc
View File

@ -23,7 +23,7 @@ size_t hash_value(DeoptimizeReason reason) {
return static_cast<uint8_t>(reason);
}
char const* const DeoptimizeReasonToString(DeoptimizeReason reason) {
char const* DeoptimizeReasonToString(DeoptimizeReason reason) {
static char const* kDeoptimizeReasonStrings[] = {
#define DEOPTIMIZE_REASON(Name, message) message,
DEOPTIMIZE_REASON_LIST(DEOPTIMIZE_REASON)

2
src/deoptimize-reason.h
View File

@ -90,7 +90,7 @@ std::ostream& operator<<(std::ostream&, DeoptimizeReason);
size_t hash_value(DeoptimizeReason reason);
char const* const DeoptimizeReasonToString(DeoptimizeReason reason);
char const* DeoptimizeReasonToString(DeoptimizeReason reason);
} // namespace internal
} // namespace v8

3
src/globals.h
View File

@ -912,7 +912,8 @@ inline bool IsDynamicVariableMode(VariableMode mode) {
inline bool IsDeclaredVariableMode(VariableMode mode) {
return mode >= VAR && mode <= CONST;
STATIC_ASSERT(VAR == 0); // Implies that mode >= VAR.
return mode <= CONST;
}