AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[heap] Disable --stress-concurrent-allocation for some tests

Browse Source 
Two tests already test concurrent allocation. Another one measures
memory, so non-deterministic allocation would lead to higher memory
usage than anticipated.

Bug: v8:10315
Change-Id: If994233c87ea04076b850ffdf024f7783653e9db
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2352781
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Commit-Queue: Dominik Inführ <dinfuehr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69383}
This commit is contained in:
Dominik Inführ 2020-08-13 14:55:14 +02:00 committed by Commit Bot
parent 34b652607a
commit 4f941eb475
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
test/cctest/heap/test-concurrent-allocation.cc
View File

@ -74,6 +74,7 @@ UNINITIALIZED_TEST(ConcurrentAllocationInOldSpace) {
FLAG_max_old_space_size = 32;
FLAG_concurrent_allocation = true;
FLAG_local_heaps = true;
FLAG_stress_concurrent_allocation = false;
v8::Isolate::CreateParams create_params;
create_params.array_buffer_allocator = CcTest::array_buffer_allocator();
@ -135,6 +136,7 @@ UNINITIALIZED_TEST(ConcurrentAllocationInLargeSpace) {
FLAG_max_old_space_size = 32;
FLAG_concurrent_allocation = true;
FLAG_local_heaps = true;
FLAG_stress_concurrent_allocation = false;
v8::Isolate::CreateParams create_params;
create_params.array_buffer_allocator = CcTest::array_buffer_allocator();

5
test/cctest/heap/test-mark-compact.cc
View File

@ -377,8 +377,9 @@ intptr_t ShortLivingIsolate() {
return MemoryInUse();
}
TEST(RegressJoinThreadsOnIsolateDeinit) {
UNINITIALIZED_TEST(RegressJoinThreadsOnIsolateDeinit) {
// Memory is measured, do not allocate in background thread.
FLAG_stress_concurrent_allocation = false;
intptr_t size_limit = ShortLivingIsolate() * 2;
for (int i = 0; i < 10; i++) {
CHECK_GT(size_limit, ShortLivingIsolate());