From 5007e30e962c293506993786237632a58b6a8650 Mon Sep 17 00:00:00 2001 From: Victor Gomes Date: Mon, 21 Nov 2022 16:48:33 +0100 Subject: [PATCH] [bazel] Add hide symbols from release build This is a reland of https://chromium-review.googlesource.com/c/v8/v8/+/3925698 Change-Id: Ic3f2084f29088fc2154931181da2b027b8ad7eff Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4042292 Auto-Submit: Victor Gomes Reviewed-by: Andreas Haas Commit-Queue: Andreas Haas Cr-Commit-Position: refs/heads/main@{#84416} --- bazel/config/BUILD.bazel | 7 +++++++ bazel/defs.bzl | 8 ++++++++ 2 files changed, 15 insertions(+) diff --git a/bazel/config/BUILD.bazel b/bazel/config/BUILD.bazel index 448260de88..7af7ccb606 100644 --- a/bazel/config/BUILD.bazel +++ b/bazel/config/BUILD.bazel @@ -22,6 +22,13 @@ config_setting( }, ) +config_setting( + name = "is_opt", + values = { + "compilation_mode": "opt", + }, +) + config_setting( name = "is_debug", values = { diff --git a/bazel/defs.bzl b/bazel/defs.bzl index 77e86ef6f2..8c3e3b9d1d 100644 --- a/bazel/defs.bzl +++ b/bazel/defs.bzl @@ -152,6 +152,14 @@ def _default_args(): ], "//conditions:default": [], }), + cxxopts = select({ + "//third_party/v8/HEAD/google3/config:is_opt": [ + "-fvisibility=hidden", + "-fvisibility-inlines-hidden", + ], + "//conditions:default": [ + ], + }), includes = ["include"], linkopts = select({ "@v8//bazel/config:is_windows": [