From 5044c510cb6773bcd518da6add2588cb973d8724 Mon Sep 17 00:00:00 2001 From: "wingo@igalia.com" Date: Tue, 11 Nov 2014 15:53:42 +0000 Subject: [PATCH] Don't print inlined function ID in --trace-hydrogen FunctionLiteral has two purposes: it is a unit of compilation, and it is also an expression. Its id() is only for the latter purpose, used by the continuation of the closure, not by the closure itself. When we inline, we treat the FunctionLiteral as a unit of compilation, not as an expression, and as such the FunctionLiteral doesn't have any meaningful ID. The right thing to do is not to access the ID when printing the hydrogen expression. R=svenpanne@chromium.org, vegorov@google.com BUG=v8:3680 LOG=N Review URL: https://codereview.chromium.org/716793003 Cr-Commit-Position: refs/heads/master@{#25267} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25267 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- src/hydrogen-instructions.cc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/hydrogen-instructions.cc b/src/hydrogen-instructions.cc index 0ec438489c..74340e8a0b 100644 --- a/src/hydrogen-instructions.cc +++ b/src/hydrogen-instructions.cc @@ -2662,8 +2662,7 @@ void HEnterInlined::RegisterReturnTarget(HBasicBlock* return_target, std::ostream& HEnterInlined::PrintDataTo(std::ostream& os) const { // NOLINT - return os << function()->debug_name()->ToCString().get() - << ", id=" << function()->id().ToInt(); + return os << function()->debug_name()->ToCString().get(); }