AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Remove TLS fetches in v8::String API implementation.

Browse Source 
Patch by Dmitry Lomov.

Original review: http://codereview.chromium.org/6716004/

TBR=ager

Review URL: http://codereview.chromium.org/6716023

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@7307 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
vitalyr@chromium.org 2011-03-22 15:16:29 +00:00
parent 118c5651c8
commit 5051d2c636
1 changed files with 14 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
src/api.cc
View File

@ -3914,14 +3914,14 @@ Local<String> v8::String::New(const char* data, int length) {
Local<String> v8::String::Concat(Handle<String> left, Handle<String> right) {
i::Isolate* isolate = i::Isolate::Current();
EnsureInitializedForIsolate(isolate, "v8::String::New()");
LOG_API(isolate, "String::New(char)");
ENTER_V8;
i::Handle<i::String> left_string = Utils::OpenHandle(*left);
i::Isolate* isolate = left_string->GetIsolate();
EnsureInitializedForIsolate(isolate, "v8::String::Concat()");
LOG_API(isolate, "String::Concat()");
ENTER_V8;
i::Handle<i::String> right_string = Utils::OpenHandle(*right);
i::Handle<i::String> result = FACTORY->NewConsString(left_string,
right_string);
i::Handle<i::String> result = isolate->factory()->NewConsString(left_string,
right_string);
return Utils::ToLocal(result);
}
@ -3933,7 +3933,8 @@ Local<String> v8::String::NewUndetectable(const char* data, int length) {
ENTER_V8;
if (length == -1) length = i::StrLength(data);
i::Handle<i::String> result =
FACTORY->NewStringFromUtf8(i::Vector<const char>(data, length));
isolate->factory()->NewStringFromUtf8(
i::Vector<const char>(data, length));
result->MarkAsUndetectable();
return Utils::ToLocal(result);
}
@ -4003,11 +4004,11 @@ Local<String> v8::String::NewExternal(
bool v8::String::MakeExternal(v8::String::ExternalStringResource* resource) {
i::Isolate* isolate = i::Isolate::Current();
i::Handle<i::String> obj = Utils::OpenHandle(this);
i::Isolate* isolate = obj->GetIsolate();
if (IsDeadCheck(isolate, "v8::String::MakeExternal()")) return false;
if (this->IsExternal()) return false; // Already an external string.
ENTER_V8;
i::Handle<i::String> obj = Utils::OpenHandle(this);
if (isolate->string_tracker()->IsFreshUnusedString(obj)) {
return false;
}
@ -4033,11 +4034,11 @@ Local<String> v8::String::NewExternal(
bool v8::String::MakeExternal(
v8::String::ExternalAsciiStringResource* resource) {
i::Isolate* isolate = i::Isolate::Current();
i::Handle<i::String> obj = Utils::OpenHandle(this);
i::Isolate* isolate = obj->GetIsolate();
if (IsDeadCheck(isolate, "v8::String::MakeExternal()")) return false;
if (this->IsExternal()) return false; // Already an external string.
ENTER_V8;
i::Handle<i::String> obj = Utils::OpenHandle(this);
if (isolate->string_tracker()->IsFreshUnusedString(obj)) {
return false;
}
@ -4050,9 +4051,9 @@ bool v8::String::MakeExternal(
bool v8::String::CanMakeExternal() {
i::Isolate* isolate = i::Isolate::Current();
if (IsDeadCheck(isolate, "v8::String::CanMakeExternal()")) return false;
i::Handle<i::String> obj = Utils::OpenHandle(this);
i::Isolate* isolate = obj->GetIsolate();
if (IsDeadCheck(isolate, "v8::String::CanMakeExternal()")) return false;
if (isolate->string_tracker()->IsFreshUnusedString(obj)) {
return false;
}