AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[cleanup] Remove unused CollectTopFrameForICStats

Browse Source 
Removes JavaScriptFrame::CollectTopFrameForICStats whose last usage was
removed in https://chromium-review.googlesource.com/626016.

Bug: v8:8834
Change-Id: I9ffad0c712816696c56b746a137bed30362550bc
Reviewed-on: https://chromium-review.googlesource.com/c/1496365
Auto-Submit: Dan Elphick <delphick@chromium.org>
Commit-Queue: Michael Starzinger <mstarzinger@chromium.org>
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#60002}
This commit is contained in:
Dan Elphick 2019-03-04 12:01:03 +00:00 committed by Commit Bot
parent 31a3cfbc10
commit 505a26fac7
2 changed files with 0 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
src/frames.cc
View File

@ -1206,32 +1206,6 @@ void JavaScriptFrame::CollectFunctionAndOffsetForICStats(JSFunction function,
}
}
void JavaScriptFrame::CollectTopFrameForICStats(Isolate* isolate) {
// constructor calls
DisallowHeapAllocation no_allocation;
JavaScriptFrameIterator it(isolate);
ICInfo& ic_info = ICStats::instance()->Current();
while (!it.done()) {
if (it.frame()->is_java_script()) {
JavaScriptFrame* frame = it.frame();
if (frame->IsConstructor()) ic_info.is_constructor = true;
JSFunction function = frame->function();
int code_offset = 0;
if (frame->is_interpreted()) {
InterpretedFrame* iframe = reinterpret_cast<InterpretedFrame*>(frame);
code_offset = iframe->GetBytecodeOffset();
} else {
Code code = frame->unchecked_code();
code_offset = static_cast<int>(frame->pc() - code->InstructionStart());
}
CollectFunctionAndOffsetForICStats(function, function->abstract_code(),
code_offset);
return;
}
it.Advance();
}
}
Object JavaScriptFrame::GetParameter(int index) const {
return Object(Memory<Address>(GetParameterSlot(index)));
}

1
src/frames.h
View File

@ -757,7 +757,6 @@ class JavaScriptFrame : public StandardFrame {
static void CollectFunctionAndOffsetForICStats(JSFunction function,
AbstractCode code,
int code_offset);
static void CollectTopFrameForICStats(Isolate* isolate);
protected:
inline explicit JavaScriptFrame(StackFrameIteratorBase* iterator);