AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Remove unused debug API.

Browse Source 
R=yurys@chromium.org

Review URL: https://codereview.chromium.org/303693010

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21590 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
yangguo@chromium.org 2014-06-02 06:22:09 +00:00
parent a52f569f93
commit 50cba82cb9
3 changed files with 4 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
include/v8-debug.h
View File

@ -139,9 +139,6 @@ class V8_EXPORT Debug {
*/
typedef void (*EventCallback)(const EventDetails& event_details);
// TODO(yangguo) Deprecate this.
typedef EventCallback EventCallback2;
/**
* Debug message callback function.
*
@ -152,9 +149,6 @@ class V8_EXPORT Debug {
*/
typedef void (*MessageHandler)(const Message& message);
// TODO(yangguo) Deprecate this.
typedef MessageHandler MessageHandler2;
/**
* Callback function for the host to ensure debug messages are processed.
*/
@ -163,12 +157,6 @@ class V8_EXPORT Debug {
static bool SetDebugEventListener(EventCallback that,
Handle<Value> data = Handle<Value>());
// TODO(yangguo) Deprecate this.
static bool SetDebugEventListener2(EventCallback2 that,
Handle<Value> data = Handle<Value>()) {
return SetDebugEventListener(that, data);
}
// Schedule a debugger break to happen when JavaScript code is run
// in the given isolate.
static void DebugBreak(Isolate* isolate);
@ -192,11 +180,6 @@ class V8_EXPORT Debug {
// Message based interface. The message protocol is JSON.
static void SetMessageHandler(MessageHandler handler);
// TODO(yangguo) Deprecate this.
static void SetMessageHandler2(MessageHandler2 handler) {
SetMessageHandler(handler);
}
static void SendCommand(Isolate* isolate,
const uint16_t* command, int length,
ClientData* client_data = NULL);

4
src/debug.cc
View File

@ -2864,8 +2864,8 @@ void Debug::CallCEventCallback(v8::DebugEvent event,
Handle<Object> event_data,
v8::Debug::ClientData* client_data) {
Handle<Foreign> callback_obj(Handle<Foreign>::cast(event_listener_));
v8::Debug::EventCallback2 callback =
FUNCTION_CAST<v8::Debug::EventCallback2>(
v8::Debug::EventCallback callback =
FUNCTION_CAST<v8::Debug::EventCallback>(
callback_obj->foreign_address());
EventDetailsImpl event_details(
event,

4
test/cctest/test-debug.cc
View File

@ -6647,7 +6647,7 @@ TEST(ProcessDebugMessagesThreaded) {
counting_message_handler_counter = 0;
v8::Debug::SetMessageHandler2(CountingMessageHandler);
v8::Debug::SetMessageHandler(CountingMessageHandler);
send_command_thread_ = new SendCommandThread(isolate);
send_command_thread_->Start();
@ -6659,7 +6659,7 @@ TEST(ProcessDebugMessagesThreaded) {
CHECK_EQ(100, counting_message_handler_counter);
v8::Debug::SetMessageHandler2(NULL);
v8::Debug::SetMessageHandler(NULL);
CheckDebuggerUnloaded();
}