[wasm][API] Remove deprecated API
The API was deprecated in v10.6 (https://crrev.com/c/3789510). Remove now, in v10.7. R=mlippautz@chromium.org Bug: v8:12899 Change-Id: I21d79cdd357315daf9684d9cdd6c1f1be088ad6b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3852490 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#82768}
This commit is contained in:
parent
e710981f3a
commit
51acc286e0
@ -327,11 +327,6 @@ using WasmSimdEnabledCallback = bool (*)(Local<Context> context);
|
|||||||
// --- Callback for checking if WebAssembly exceptions are enabled ---
|
// --- Callback for checking if WebAssembly exceptions are enabled ---
|
||||||
using WasmExceptionsEnabledCallback = bool (*)(Local<Context> context);
|
using WasmExceptionsEnabledCallback = bool (*)(Local<Context> context);
|
||||||
|
|
||||||
// --- Callback for checking if WebAssembly dynamic tiering is enabled ---
|
|
||||||
using WasmDynamicTieringEnabledCallback V8_DEPRECATED(
|
|
||||||
"Dynamic tiering is now enabled by default") =
|
|
||||||
bool (*)(Local<Context> context);
|
|
||||||
|
|
||||||
// --- Callback for checking if the SharedArrayBuffer constructor is enabled ---
|
// --- Callback for checking if the SharedArrayBuffer constructor is enabled ---
|
||||||
using SharedArrayBufferConstructorEnabledCallback =
|
using SharedArrayBufferConstructorEnabledCallback =
|
||||||
bool (*)(Local<Context> context);
|
bool (*)(Local<Context> context);
|
||||||
|
@ -1528,10 +1528,6 @@ class V8_EXPORT Isolate {
|
|||||||
|
|
||||||
void SetWasmExceptionsEnabledCallback(WasmExceptionsEnabledCallback callback);
|
void SetWasmExceptionsEnabledCallback(WasmExceptionsEnabledCallback callback);
|
||||||
|
|
||||||
V8_DEPRECATED("Dynamic tiering is now enabled by default")
|
|
||||||
void SetWasmDynamicTieringEnabledCallback(WasmDynamicTieringEnabledCallback) {
|
|
||||||
}
|
|
||||||
|
|
||||||
void SetSharedArrayBufferConstructorEnabledCallback(
|
void SetSharedArrayBufferConstructorEnabledCallback(
|
||||||
SharedArrayBufferConstructorEnabledCallback callback);
|
SharedArrayBufferConstructorEnabledCallback callback);
|
||||||
|
|
||||||
|
@ -125,15 +125,6 @@ struct WasmModuleInstantiated {
|
|||||||
int64_t wall_clock_duration_in_us = -1;
|
int64_t wall_clock_duration_in_us = -1;
|
||||||
};
|
};
|
||||||
|
|
||||||
struct V8_DEPRECATED(
|
|
||||||
"With dynamic tiering, there is no point any more where the module is "
|
|
||||||
"fully tiered up") WasmModuleTieredUp {
|
|
||||||
bool lazy = false;
|
|
||||||
size_t code_size_in_bytes = 0;
|
|
||||||
int64_t wall_clock_duration_in_us = -1;
|
|
||||||
int64_t cpu_duration_in_us = -1;
|
|
||||||
};
|
|
||||||
|
|
||||||
struct WasmModulesPerIsolate {
|
struct WasmModulesPerIsolate {
|
||||||
size_t count = 0;
|
size_t count = 0;
|
||||||
};
|
};
|
||||||
@ -190,11 +181,6 @@ class V8_EXPORT Recorder {
|
|||||||
ADD_MAIN_THREAD_EVENT(WasmModuleDecoded)
|
ADD_MAIN_THREAD_EVENT(WasmModuleDecoded)
|
||||||
ADD_MAIN_THREAD_EVENT(WasmModuleCompiled)
|
ADD_MAIN_THREAD_EVENT(WasmModuleCompiled)
|
||||||
ADD_MAIN_THREAD_EVENT(WasmModuleInstantiated)
|
ADD_MAIN_THREAD_EVENT(WasmModuleInstantiated)
|
||||||
|
|
||||||
V8_DEPRECATED(
|
|
||||||
"With dynamic tiering, there is no point any more where the module is "
|
|
||||||
"fully tiered up")
|
|
||||||
ADD_MAIN_THREAD_EVENT(WasmModuleTieredUp)
|
|
||||||
#undef ADD_MAIN_THREAD_EVENT
|
#undef ADD_MAIN_THREAD_EVENT
|
||||||
|
|
||||||
// Thread-safe events are not allowed to access the context and therefore do
|
// Thread-safe events are not allowed to access the context and therefore do
|
||||||
|
@ -131,20 +131,6 @@ class V8_EXPORT WasmStreaming final {
|
|||||||
public:
|
public:
|
||||||
class WasmStreamingImpl;
|
class WasmStreamingImpl;
|
||||||
|
|
||||||
/**
|
|
||||||
* Client to receive streaming event notifications.
|
|
||||||
*/
|
|
||||||
class V8_DEPRECATED("Use SetMoreFunctionsCanBeSerializedCallback") Client {
|
|
||||||
public:
|
|
||||||
virtual ~Client() = default;
|
|
||||||
|
|
||||||
/**
|
|
||||||
* Passes the fully compiled module to the client. This can be used to
|
|
||||||
* implement code caching.
|
|
||||||
*/
|
|
||||||
virtual void OnModuleCompiled(CompiledWasmModule) = 0;
|
|
||||||
};
|
|
||||||
|
|
||||||
explicit WasmStreaming(std::unique_ptr<WasmStreamingImpl> impl);
|
explicit WasmStreaming(std::unique_ptr<WasmStreamingImpl> impl);
|
||||||
|
|
||||||
~WasmStreaming();
|
~WasmStreaming();
|
||||||
@ -184,13 +170,6 @@ class V8_EXPORT WasmStreaming final {
|
|||||||
*/
|
*/
|
||||||
bool SetCompiledModuleBytes(const uint8_t* bytes, size_t size);
|
bool SetCompiledModuleBytes(const uint8_t* bytes, size_t size);
|
||||||
|
|
||||||
/**
|
|
||||||
* Sets the client object that will receive streaming event notifications.
|
|
||||||
* This must be called before {OnBytesReceived}, {Finish}, or {Abort}.
|
|
||||||
*/
|
|
||||||
V8_DEPRECATED("Use SetMoreFunctionsCanBeSerializedCallback")
|
|
||||||
void SetClient(std::shared_ptr<Client> client);
|
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Sets a callback which is called whenever a significant number of new
|
* Sets a callback which is called whenever a significant number of new
|
||||||
* functions are ready for serialization.
|
* functions are ready for serialization.
|
||||||
|
@ -10482,8 +10482,6 @@ bool WasmStreaming::SetCompiledModuleBytes(const uint8_t* bytes, size_t size) {
|
|||||||
UNREACHABLE();
|
UNREACHABLE();
|
||||||
}
|
}
|
||||||
|
|
||||||
void WasmStreaming::SetClient(std::shared_ptr<Client> client) { UNREACHABLE(); }
|
|
||||||
|
|
||||||
void WasmStreaming::SetMoreFunctionsCanBeSerializedCallback(
|
void WasmStreaming::SetMoreFunctionsCanBeSerializedCallback(
|
||||||
std::function<void(CompiledWasmModule)>) {
|
std::function<void(CompiledWasmModule)>) {
|
||||||
UNREACHABLE();
|
UNREACHABLE();
|
||||||
|
@ -80,18 +80,6 @@ class WasmStreaming::WasmStreamingImpl {
|
|||||||
return true;
|
return true;
|
||||||
}
|
}
|
||||||
|
|
||||||
START_ALLOW_USE_DEPRECATED()
|
|
||||||
void SetClient(std::shared_ptr<Client> client) {
|
|
||||||
streaming_decoder_->SetMoreFunctionsCanBeSerializedCallback(
|
|
||||||
[client, streaming_decoder = streaming_decoder_](
|
|
||||||
const std::shared_ptr<i::wasm::NativeModule>& native_module) {
|
|
||||||
base::Vector<const char> url = streaming_decoder->url();
|
|
||||||
client->OnModuleCompiled(
|
|
||||||
CompiledWasmModule{native_module, url.begin(), url.size()});
|
|
||||||
});
|
|
||||||
}
|
|
||||||
END_ALLOW_USE_DEPRECATED()
|
|
||||||
|
|
||||||
void SetMoreFunctionsCanBeSerializedCallback(
|
void SetMoreFunctionsCanBeSerializedCallback(
|
||||||
std::function<void(CompiledWasmModule)> callback) {
|
std::function<void(CompiledWasmModule)> callback) {
|
||||||
streaming_decoder_->SetMoreFunctionsCanBeSerializedCallback(
|
streaming_decoder_->SetMoreFunctionsCanBeSerializedCallback(
|
||||||
@ -140,11 +128,6 @@ bool WasmStreaming::SetCompiledModuleBytes(const uint8_t* bytes, size_t size) {
|
|||||||
return impl_->SetCompiledModuleBytes(base::VectorOf(bytes, size));
|
return impl_->SetCompiledModuleBytes(base::VectorOf(bytes, size));
|
||||||
}
|
}
|
||||||
|
|
||||||
void WasmStreaming::SetClient(std::shared_ptr<Client> client) {
|
|
||||||
TRACE_EVENT0("v8.wasm", "wasm.WasmStreaming.SetClient");
|
|
||||||
impl_->SetClient(client);
|
|
||||||
}
|
|
||||||
|
|
||||||
void WasmStreaming::SetMoreFunctionsCanBeSerializedCallback(
|
void WasmStreaming::SetMoreFunctionsCanBeSerializedCallback(
|
||||||
std::function<void(CompiledWasmModule)> callback) {
|
std::function<void(CompiledWasmModule)> callback) {
|
||||||
impl_->SetMoreFunctionsCanBeSerializedCallback(std::move(callback));
|
impl_->SetMoreFunctionsCanBeSerializedCallback(std::move(callback));
|
||||||
|
Loading…
Reference in New Issue
Block a user