AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[maglev] Temporarily disable in-heap Typed Array support

Browse Source 
Commit 5d3e12941e
introduced support for in-heap Typed Arrays in Maglev. This is causing
a bug in the register allocator, that is taking me a while to fix. I'm
thus temporarily disabled this in-heap Typed Array support until I've
fixed the register allocator bug.

Fixed: v8:13639
Bug: v8:7700
Change-Id: Ic121bafcd22e248a5a340baec7d10a265a5a711a
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4146422
Reviewed-by: Victor Gomes <victorgomes@chromium.org>
Auto-Submit: Darius Mercadier <dmercadier@chromium.org>
Commit-Queue: Victor Gomes <victorgomes@chromium.org>
Cr-Commit-Position: refs/heads/main@{#85134}
This commit is contained in:
Darius M 2023-01-09 08:44:28 +01:00 committed by V8 LUCI CQ
parent cebcd8c51b
commit 521a399d35
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/maglev/maglev-graph-builder.cc
View File

@ -2213,6 +2213,10 @@ bool MaglevGraphBuilder::TryBuildElementAccess(
// TODO(victorgomes): Support more elements kind.
ElementsKind elements_kind = access_info.elements_kind();
if (IsTypedArrayElementsKind(elements_kind)) {
if (JSTypedArray::kMaxSizeInHeap != 0) {
// TODO(dmercadier): re-enable support for in-heap Typed Arrays.
return false;
}
if (elements_kind == BIGUINT64_ELEMENTS ||
elements_kind == BIGINT64_ELEMENTS) {
return false;