From 52596006db5a74187e6076f1c0666b9bc4f065c5 Mon Sep 17 00:00:00 2001 From: Santiago Aboy Solanes Date: Thu, 15 Apr 2021 15:17:39 +0100 Subject: [PATCH] Reland "[compiler] Do MapRef::CanBeDeprecated and ::CanTransition concurrently" This is a reland of abe4858b0a0fd5dbde4a69d16ba2fa062d599a6d Reason: It was speculatively reverted but it doesn't seem to have been the culprit. TBR=neis@chromium.org Original change's description: > [compiler] Do MapRef::CanBeDeprecated and ::CanTransition concurrently > > CanBeDeprecated looks at the DescriptorArray, and CanTransition at the > instance_type. Both are safe to read concurrently and we just had to > enable them with the macro. > > Bug: v8:7790 > Change-Id: Iafe6470f2d64a9ed38383cb9e4d00dd6f23d05d7 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2826539 > Reviewed-by: Georg Neis > Commit-Queue: Santiago Aboy Solanes > Cr-Commit-Position: refs/heads/master@{#73995} Bug: v8:7790 Change-Id: I51d29d53b208fe9b6b27adc46561a4e1009e8d6f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2831488 Reviewed-by: Santiago Aboy Solanes Commit-Queue: Santiago Aboy Solanes Cr-Commit-Position: refs/heads/master@{#74007} --- src/compiler/js-heap-broker.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/compiler/js-heap-broker.cc b/src/compiler/js-heap-broker.cc index a71ca801f6..3daac6a062 100644 --- a/src/compiler/js-heap-broker.cc +++ b/src/compiler/js-heap-broker.cc @@ -3838,13 +3838,13 @@ bool MapRef::is_stable() const { } bool MapRef::CanBeDeprecated() const { - IF_ACCESS_FROM_HEAP_C(CanBeDeprecated); + IF_ACCESS_FROM_HEAP_WITH_FLAG_C(CanBeDeprecated); CHECK_GT(NumberOfOwnDescriptors(), 0); return data()->AsMap()->can_be_deprecated(); } bool MapRef::CanTransition() const { - IF_ACCESS_FROM_HEAP_C(CanTransition); + IF_ACCESS_FROM_HEAP_WITH_FLAG_C(CanTransition); return data()->AsMap()->can_transition(); }