From 53194b44ba44a11a35ad1ffaaf75f506b7378853 Mon Sep 17 00:00:00 2001 From: "mvstanton@chromium.org" Date: Thu, 19 Sep 2013 13:32:00 +0000 Subject: [PATCH] Allocation site tests aren't compatible with GcStress mode. They make assumptions about elementskind of arrays based on allocation site feedback. This feedback is highly dependent on mementos, unrooted objects placed behind arrays in the heap meant to live until the next scavenge. GcStress does many more gcs than normal, and wrecks havoc with this kind of test. BUG= R=hpayer@chromium.org Review URL: https://codereview.chromium.org/23449042 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16832 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- test/mjsunit/allocation-site-info.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/test/mjsunit/allocation-site-info.js b/test/mjsunit/allocation-site-info.js index 0f5870d7d9..dd22f573f0 100644 --- a/test/mjsunit/allocation-site-info.js +++ b/test/mjsunit/allocation-site-info.js @@ -35,6 +35,11 @@ // in this test case. Depending on whether smi-only arrays are actually // enabled, this test takes the appropriate code path to check smi-only arrays. +// Reset the GC stress mode to be off. Needed because AllocationMementos only +// live for one gc, so a gc that happens in certain fragile areas of the test +// can break assumptions. +%SetFlags("--gc-interval=-1") + // support_smi_only_arrays = %HasFastSmiElements(new Array(1,2,3,4,5,6,7,8)); support_smi_only_arrays = true;