AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[interpreter] Add a comment regarding CreateArrayFromIterable

Browse Source 
R=rmcilroy@chromium.org

Change-Id: I41739db4d6cb06e798ff6a323a526329b4ac0af4
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1562132
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Commit-Queue: Georg Neis <neis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#60826}
This commit is contained in:
Georg Neis 2019-04-10 19:52:47 +02:00 committed by Commit Bot
parent 6832f29250
commit 549031b44f
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/interpreter/interpreter-generator.cc
View File

@ -1430,11 +1430,10 @@ IGNITION_HANDLER(Inc, IncDecAssembler) { IncWithFeedback(); }
// Decrements value in the accumulator by one. // Decrements value in the accumulator by one.
IGNITION_HANDLER(Dec, IncDecAssembler) { DecWithFeedback(); } IGNITION_HANDLER(Dec, IncDecAssembler) { DecWithFeedback(); }
// LogicalNot // ToBooleanLogicalNot
// //
// Perform logical-not on the accumulator, first casting the // Perform logical-not on the accumulator, first casting the
// accumulator to a boolean value if required. // accumulator to a boolean value if required.
// ToBooleanLogicalNot
IGNITION_HANDLER(ToBooleanLogicalNot, InterpreterAssembler) { IGNITION_HANDLER(ToBooleanLogicalNot, InterpreterAssembler) {
Node* value = GetAccumulator(); Node* value = GetAccumulator();
Variable result(this, MachineRepresentation::kTagged); Variable result(this, MachineRepresentation::kTagged);
@ -2487,6 +2486,7 @@ IGNITION_HANDLER(CreateEmptyArrayLiteral, InterpreterAssembler) {
// CreateArrayFromIterable // CreateArrayFromIterable
// //
// Spread the given iterable from the accumulator into a new JSArray. // Spread the given iterable from the accumulator into a new JSArray.
// TODO(neis): Turn this into an intrinsic when we're running out of bytecodes.
IGNITION_HANDLER(CreateArrayFromIterable, InterpreterAssembler) { IGNITION_HANDLER(CreateArrayFromIterable, InterpreterAssembler) {
Node* iterable = GetAccumulator(); Node* iterable = GetAccumulator();
Node* context = GetContext(); Node* context = GetContext();