AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Unify canonicalization of HAdd/HSub/HMul a bit.

Browse Source 
HDiv/HMul are a slightly different story and will be handled in a separate CL.

Review URL: https://codereview.chromium.org/14296013

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14322 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
svenpanne@chromium.org 2013-04-18 09:24:29 +00:00
parent 5a21512936
commit 55324693aa
2 changed files with 20 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
src/hydrogen-instructions.cc
View File

@ -1422,21 +1422,14 @@ HValue* HBitNot::Canonicalize() {
}
HValue* HAdd::Canonicalize() {
if (!representation().IsInteger32()) return this;
if (CheckUsesForFlag(kTruncatingToInt32)) ClearFlag(kCanOverflow);
HValue* HArithmeticBinaryOperation::Canonicalize() {
if (representation().IsInteger32() && CheckUsesForFlag(kTruncatingToInt32)) {
ClearFlag(kCanOverflow);
}
return this;
}
HValue* HSub::Canonicalize() {
if (!representation().IsInteger32()) return this;
if (CheckUsesForFlag(kTruncatingToInt32)) ClearFlag(kCanOverflow);
return this;
}
// TODO(svenpanne) Use this in other Canonicalize() functions.
static bool IsIdentityOperation(HValue* arg1, HValue* arg2, int32_t identity) {
return arg1->representation().IsSpecialization() &&
arg2->IsInteger32Constant() &&
@ -1444,10 +1437,23 @@ static bool IsIdentityOperation(HValue* arg1, HValue* arg2, int32_t identity) {
}
HValue* HAdd::Canonicalize() {
if (IsIdentityOperation(left(), right(), 0)) return left();
if (IsIdentityOperation(right(), left(), 0)) return right();
return HArithmeticBinaryOperation::Canonicalize();
}
HValue* HSub::Canonicalize() {
if (IsIdentityOperation(left(), right(), 0)) return left();
return HArithmeticBinaryOperation::Canonicalize();
}
HValue* HMul::Canonicalize() {
if (IsIdentityOperation(left(), right(), 1)) return left();
if (IsIdentityOperation(right(), left(), 1)) return right();
return this;
return HArithmeticBinaryOperation::Canonicalize();
}

2
src/hydrogen-instructions.h
View File

@ -3842,6 +3842,8 @@ class HArithmeticBinaryOperation: public HBinaryOperation {
: representation();
}
virtual HValue* Canonicalize();
private:
virtual bool IsDeletable() const { return true; }
};