AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

make deleted functions public in include

Browse Source 
Effective Modern C++ Items 11:
Prefer deleted functions to private undefined ones


Change-Id: I35c6277fcc77c60fc0a3d904763039c916d62b78
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1608325
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#61433}
This commit is contained in:
gengjiawen 2019-05-12 23:50:25 +08:00 committed by Commit Bot
parent 4eba72fd88
commit 5554781f74
5 changed files with 10 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
AUTHORS
View File

@ -102,6 +102,7 @@ Jay Freeman <saurik@saurik.com>
James Pike <g00gle@chilon.net> James Pike <g00gle@chilon.net>
James M Snell <jasnell@gmail.com> James M Snell <jasnell@gmail.com>
Jianghua Yang <jianghua.yjh@alibaba-inc.com> Jianghua Yang <jianghua.yjh@alibaba-inc.com>
Jiawen Geng <technicalcute@gmail.com>
Joel Stanley <joel@jms.id.au> Joel Stanley <joel@jms.id.au>
Johan Bergström <johan@bergstroem.nu> Johan Bergström <johan@bergstroem.nu>
Jonathan Liu <net147@gmail.com> Jonathan Liu <net147@gmail.com>

1
include/v8-inspector.h
View File

@ -87,7 +87,6 @@ class V8_EXPORT V8ContextInfo {
static int executionContextId(v8::Local<v8::Context> context); static int executionContextId(v8::Local<v8::Context> context);
private:
// Disallow copying and allocating this one. // Disallow copying and allocating this one.
enum NotNullTagEnum { NotNullLiteral }; enum NotNullTagEnum { NotNullLiteral };
void* operator new(size_t) = delete; void* operator new(size_t) = delete;

1
include/v8-platform.h
View File

@ -109,7 +109,6 @@ class TaskRunner {
TaskRunner() = default; TaskRunner() = default;
virtual ~TaskRunner() = default; virtual ~TaskRunner() = default;
private:
TaskRunner(const TaskRunner&) = delete; TaskRunner(const TaskRunner&) = delete;
TaskRunner& operator=(const TaskRunner&) = delete; TaskRunner& operator=(const TaskRunner&) = delete;
}; };

1
include/v8-profiler.h
View File

@ -792,7 +792,6 @@ class V8_EXPORT EmbedderGraph {
*/ */
virtual const char* NamePrefix() { return nullptr; } virtual const char* NamePrefix() { return nullptr; }
private:
Node(const Node&) = delete; Node(const Node&) = delete;
Node& operator=(const Node&) = delete; Node& operator=(const Node&) = delete;
}; };

17
include/v8.h
View File

@ -2093,10 +2093,10 @@ class V8_EXPORT ValueSerializer {
void WriteDouble(double value); void WriteDouble(double value);
void WriteRawBytes(const void* source, size_t length); void WriteRawBytes(const void* source, size_t length);
private:
ValueSerializer(const ValueSerializer&) = delete; ValueSerializer(const ValueSerializer&) = delete;
void operator=(const ValueSerializer&) = delete; void operator=(const ValueSerializer&) = delete;
private:
struct PrivateData; struct PrivateData;
PrivateData* private_; PrivateData* private_;
}; };
@ -2195,10 +2195,10 @@ class V8_EXPORT ValueDeserializer {
V8_WARN_UNUSED_RESULT bool ReadDouble(double* value); V8_WARN_UNUSED_RESULT bool ReadDouble(double* value);
V8_WARN_UNUSED_RESULT bool ReadRawBytes(size_t length, const void** data); V8_WARN_UNUSED_RESULT bool ReadRawBytes(size_t length, const void** data);
private:
ValueDeserializer(const ValueDeserializer&) = delete; ValueDeserializer(const ValueDeserializer&) = delete;
void operator=(const ValueDeserializer&) = delete; void operator=(const ValueDeserializer&) = delete;
private:
struct PrivateData; struct PrivateData;
PrivateData* private_; PrivateData* private_;
}; };
@ -2721,6 +2721,10 @@ class V8_EXPORT String : public Name {
*/ */
virtual bool IsCacheable() const { return true; } virtual bool IsCacheable() const { return true; }
// Disallow copying and assigning.
ExternalStringResourceBase(const ExternalStringResourceBase&) = delete;
void operator=(const ExternalStringResourceBase&) = delete;
protected: protected:
ExternalStringResourceBase() = default; ExternalStringResourceBase() = default;
@ -2750,10 +2754,6 @@ class V8_EXPORT String : public Name {
*/ */
virtual void Unlock() const {} virtual void Unlock() const {}
// Disallow copying and assigning.
ExternalStringResourceBase(const ExternalStringResourceBase&) = delete;
void operator=(const ExternalStringResourceBase&) = delete;
private: private:
friend class internal::ExternalString; friend class internal::ExternalString;
friend class v8::String; friend class v8::String;
@ -6721,11 +6721,12 @@ class V8_EXPORT MicrotaskQueue {
*/ */
virtual int GetMicrotasksScopeDepth() const = 0; virtual int GetMicrotasksScopeDepth() const = 0;
MicrotaskQueue(const MicrotaskQueue&) = delete;
MicrotaskQueue& operator=(const MicrotaskQueue&) = delete;
private: private:
friend class internal::MicrotaskQueue; friend class internal::MicrotaskQueue;
MicrotaskQueue() = default; MicrotaskQueue() = default;
MicrotaskQueue(const MicrotaskQueue&) = delete;
MicrotaskQueue& operator=(const MicrotaskQueue&) = delete;
}; };
/** /**