AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[inspector] Mark pause-on-oom tests are flaky

Browse Source 
Instead of using SKIP (which would skip the tests), we can use
[PASS, FAIL] which signals to run the tests and accept if they are
flakily passing. In this way, we would get coverage and an error if we
have a non-flaky failure.

Bug: v8:10876
Change-Id: Idbdf9dcb76775cf5e81dc1c3bc6d9abb1db23ced
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2401424
Auto-Submit: Santiago Aboy Solanes <solanes@chromium.org>
Commit-Queue: Sathya Gunasekaran  <gsathya@chromium.org>
Reviewed-by: Sathya Gunasekaran  <gsathya@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69790}
This commit is contained in:
Santiago Aboy Solanes 2020-09-09 16:28:29 +01:00 committed by Commit Bot
parent 90ec63a98d
commit 5587838ec7
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
test/inspector/inspector.status
View File

@ -23,9 +23,9 @@
##############################################################################
['arch == x64 and mode == debug', {
# https://crbug.com/v8/10876
'debugger/pause-on-oom-extrawide': [SKIP],
'debugger/pause-on-oom-wide': [SKIP],
# Flaky tests: https://crbug.com/v8/10876
'debugger/pause-on-oom-extrawide': [PASS, FAIL],
'debugger/pause-on-oom-wide': [PASS, FAIL],
}], # 'arch == x64 and mode == debug'
##############################################################################