AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[tools] Remove near_timeouts and timeouts fields

Browse Source 
R=machenbach@chromium.org, tmrts@chromium.org

No-Tree-Checks: true
Bug: chromium:841700
Change-Id: I201f3f029406bf788182e3cc6cf62ff68839a00d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1603802
Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#61420}
This commit is contained in:
Sergiy Belozorov 2019-05-09 23:45:01 +02:00 committed by Commit Bot
parent 40d9fca804
commit 55a7c6a5af
1 changed files with 0 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
tools/run_perf.py
View File

@ -178,20 +178,11 @@ class ResultTracker(object):
...
],
"errors": [<list of strings describing errors>],
# These two fields are deprecated and will soon be removed.
"timeouts": [<list of traces which have timed out at least once>],
"near_timeouts": [<list of traces which have at least once run for longer
than 90% of the configured timeout>],
}
"""
def __init__(self):
self.traces = {}
self.errors = []
# TODO(sergiyb): Deprecate self.timeouts/near_timeouts and compute them in
# the recipe based on self.runnable_durations. Also cleanup RunnableConfig
# by removing has_timeouts/has_near_timeouts there.
self.timeouts = []
self.near_timeouts = [] # > 90% of the max runtime
self.runnables = {}
def AddTraceResult(self, trace, result, stddev):
@ -234,8 +225,6 @@ class ResultTracker(object):
return {
'traces': self.traces.values(),
'errors': self.errors,
'timeouts': self.timeouts,
'near_timeouts': self.near_timeouts,
'runnables': self.runnables.values(),
}
@ -454,8 +443,6 @@ class RunnableConfig(GraphConfig):
"""
def __init__(self, suite, parent, arch):
super(RunnableConfig, self).__init__(suite, parent, arch)
self.has_timeouts = False
self.has_near_timeouts = False
self.arch = arch
@property
@ -619,15 +606,11 @@ class Platform(object):
except OSError:
logging.exception(title % 'OSError')
raise
if output.duration > 0.9 * runnable.timeout:
runnable.has_near_timeouts = True
if output.stdout:
logging.info(title % 'Stdout' + '\n%s', output.stdout)
if output.stderr: # pragma: no cover
# Print stderr for debugging.
logging.info(title % 'Stderr' + '\n%s', output.stderr)
if output.timed_out:
runnable.has_timeouts = True
logging.warning('>>> Test timed out after %ss.', runnable.timeout)
if output.exit_code != 0:
logging.warning('>>> Test crashed with exit code %d.', output.exit_code)
@ -1108,11 +1091,6 @@ def Main(argv):
have_failed_tests = True
if attempts_left:
logging.info('>>> Retrying suite: %s', runnable_name)
if runnable.has_timeouts:
result_tracker.timeouts.append(runnable_name)
if runnable.has_near_timeouts:
result_tracker.near_timeouts.append(runnable_name)
except MaxTotalDurationReachedError:
have_failed_tests = True