From 55ae1a523961a7d0e08ba4ea9300da0a9817a15e Mon Sep 17 00:00:00 2001 From: Dan Elphick Date: Wed, 28 Apr 2021 16:50:33 +0100 Subject: [PATCH] Reland "[build] Enable gn check for most of v8" This is a reland of dbd5ae5296e853c5f64e7197354187821721456b Less common configs were fixed in other CLs. Original change's description: > [build] Enable gn check for most of v8 > > Currently there are 32 gn check failures across v8 (not including > third_party). These are due to issues in cppgc and inspector, which are > not trivially resolveable, so for now 4 targets (+ third_party) are > being excluded from the checks. > > Bug: v8:7330 > Change-Id: I506abe8e452c26239262499fc1fe2a6347a4c84b > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2851886 > Reviewed-by: Michael Achenbach > Commit-Queue: Dan Elphick > Cr-Commit-Position: refs/heads/master@{#74255} Bug: v8:7330 Change-Id: I82047cfa7f8213312158123885808c2a4ad02160 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2859842 Commit-Queue: Dan Elphick Commit-Queue: Michael Achenbach Auto-Submit: Dan Elphick Reviewed-by: Michael Achenbach Cr-Commit-Position: refs/heads/master@{#74278} --- .gn | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/.gn b/.gn index d4ad959954..028a530ffd 100644 --- a/.gn +++ b/.gn @@ -11,7 +11,13 @@ buildconfig = "//build/config/BUILDCONFIG.gn" # matching these patterns (see "gn help label_pattern" for format) will have # their includes checked for proper dependencies when you run either # "gn check" or "gn gen --check". -check_targets = [] +no_check_targets = [ + "//:cppgc_base", + "//:v8_internal_headers", + "//src/inspector:inspector", + "//test/cctest:cctest_sources", + "//third_party/*", +] # These are the list of GN files that run exec_script. This whitelist exists # to force additional review for new uses of exec_script, which is strongly