AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[cleanup] Remove Movability from globals.h

Browse Source 
It was once widely used throughout v8 but now there is no need for it
anymore.

Bug: v8:9183
Change-Id: Id766987d468383cf459414eb5edfdee71b83a60b
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1585839
Commit-Queue: Maciej Goszczycki <goszczycki@google.com>
Reviewed-by: Hannes Payer <hpayer@chromium.org>
Reviewed-by: Dan Elphick <delphick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#61098}
This commit is contained in:
Maciej Goszczycki 2019-04-29 17:17:21 +01:00 committed by Commit Bot
parent 8e01d664dc
commit 561b9b07fd
3 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/globals.h
View File

@ -772,8 +772,6 @@ enum GarbageCollector { SCAVENGER, MARK_COMPACTOR, MINOR_MARK_COMPACTOR };
enum Executability { NOT_EXECUTABLE, EXECUTABLE };
enum Movability { kMovable, kImmovable };
enum VisitMode {
VISIT_ALL,
VISIT_ALL_IN_MINOR_MC_MARK,

2
src/heap/factory.cc
View File

@ -105,7 +105,7 @@ MaybeHandle<Code> Factory::CodeBuilder::BuildInternal(bool failing_allocation) {
heap->AllocateRawWithRetryOrFail(object_size, AllocationType::kCode);
}
if (movability_ == kImmovable) {
if (!is_movable_) {
result = heap->EnsureImmovableCode(result, object_size);
}

4
src/heap/factory.h
View File

@ -969,7 +969,7 @@ class V8_EXPORT_PRIVATE Factory {
return *this;
}
CodeBuilder& set_immovable() {
movability_ = kImmovable;
is_movable_ = false;
return *this;
}
CodeBuilder& set_is_turbofanned() {
@ -993,7 +993,7 @@ class V8_EXPORT_PRIVATE Factory {
Handle<ByteArray> source_position_table_;
Handle<DeoptimizationData> deoptimization_data_ =
DeoptimizationData::Empty(isolate_);
Movability movability_ = kMovable;
bool is_movable_ = true;
bool is_turbofanned_ = false;
int stack_slots_ = 0;
};