AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Skip src/maglev for v8_check_header_includes

Browse Source 
Maglev is currently enabled only on x64; BUILD.gn knows about this
through v8_enable_maglev, but v8_check_header_includes doesn't. It
thus tries to compile maglev files on platforms that don't have maglev
support yet.

Add an explicit maglev exclude rule until we support other platforms.

Bug: v8:7700
Change-Id: Iac991741c7d630dc4ed9f9fbf6df7656853cc743
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3494536
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Auto-Submit: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/main@{#79305}
This commit is contained in:
Jakob Gruber 2022-02-28 11:09:39 +01:00 committed by V8 LUCI CQ
parent 95c4483120
commit 56c6873507
1 changed files with 10 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
tools/generate-header-include-checks.py
View File

@ -37,14 +37,17 @@ AUTO_EXCLUDE = [
'src/trap-handler/trap-handler-simulator.h',
]
AUTO_EXCLUDE_PATTERNS = [
'src/base/atomicops_internals_.*',
# TODO(petermarshall): Enable once Perfetto is built by default.
'src/libplatform/tracing/perfetto*',
'src/base/atomicops_internals_.*',
# TODO(petermarshall): Enable once Perfetto is built by default.
'src/libplatform/tracing/perfetto*',
# TODO(v8:7700): Enable once Maglev is built by default.
'src/maglev/.*',
] + [
# platform-specific headers
'\\b{}\\b'.format(p) for p in
('win', 'win32', 'ia32', 'x64', 'arm', 'arm64', 'mips', 'mips64', 's390',
'ppc', 'riscv64', 'loong64')]
# platform-specific headers
'\\b{}\\b'.format(p)
for p in ('win', 'win32', 'ia32', 'x64', 'arm', 'arm64', 'mips', 'mips64',
's390', 'ppc', 'riscv64', 'loong64')
]
args = None
def parse_args():