AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[builtins] Increase default buffer size

Browse Source 
MSVC is not happy about conditionally increasing the buffer size for
builtin code generation with --code-comments.

Previous CL: https://crrev.com/c/2976651

Change-Id: Ic257eecfc9c41835d8ae4cf2de595fd5c427a7e2
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2992721
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#75450}
This commit is contained in:
Camillo Bruni 2021-06-29 16:44:28 +02:00 committed by V8 LUCI CQ
parent 4ccebb6f5e
commit 58406c760c
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/builtins/setup-builtins-internal.cc
View File

@ -31,6 +31,8 @@ BUILTIN_LIST_C(FORWARD_DECLARE)
namespace {
const int kBufferSize = 128 * KB;
AssemblerOptions BuiltinAssemblerOptions(Isolate* isolate, Builtin builtin) {
AssemblerOptions options = AssemblerOptions::Default(isolate);
CHECK(!options.isolate_independent_code);
@ -59,7 +61,6 @@ using CodeAssemblerGenerator = void (*)(compiler::CodeAssemblerState*);
Handle<Code> BuildPlaceholder(Isolate* isolate, Builtin builtin) {
HandleScope scope(isolate);
const int kBufferSize = FLAG_code_comments ? 128 * KB : 1 * KB;
byte buffer[kBufferSize];
MacroAssembler masm(isolate, CodeObjectRequired::kYes,
ExternalAssemblerBuffer(buffer, kBufferSize));
@ -87,7 +88,6 @@ Code BuildWithMacroAssembler(Isolate* isolate, Builtin builtin,
// Canonicalize handles, so that we can share constant pool entries pointing
// to code targets without dereferencing their handles.
CanonicalHandleScope canonical(isolate);
const int kBufferSize = FLAG_code_comments ? 128 * KB : 32 * KB;
byte buffer[kBufferSize];
MacroAssembler masm(isolate, BuiltinAssemblerOptions(isolate, builtin),
@ -130,7 +130,6 @@ Code BuildAdaptor(Isolate* isolate, Builtin builtin, Address builtin_address,
// Canonicalize handles, so that we can share constant pool entries pointing
// to code targets without dereferencing their handles.
CanonicalHandleScope canonical(isolate);
const int kBufferSize = FLAG_code_comments ? 128 * KB : 32 * KB;
byte buffer[kBufferSize];
MacroAssembler masm(isolate, BuiltinAssemblerOptions(isolate, builtin),
CodeObjectRequired::kYes,