AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[test] Fix UBSan failure

Browse Source 
UBSan starts complaining about a nullptr destination in memcpy after
https://crrev.com/c/2691828.
This CL fixes the error by not copying if there is nothing to copy.

R=nicohartmann@chromium.org

No-Try: true
No-Tree-Checks: true
Change-Id: I2c941b37d26931d6c2253bc3bb2c0aa659d4cb71
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2690605
Commit-Queue: Nico Hartmann <nicohartmann@chromium.org>
Reviewed-by: Nico Hartmann <nicohartmann@chromium.org>
Cr-Commit-Position: refs/heads/master@{#72690}
This commit is contained in:
Clemens Backes 2021-02-12 12:17:34 +01:00 committed by Commit Bot
parent e5cf754b67
commit 587e7163cd
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
test/cctest/compiler/c-signature.h
View File

@ -100,8 +100,10 @@ class CSignatureOf : public CSignature {
static_assert( static_assert(
std::is_same<decltype(*reps_), decltype(*param_types.data())>::value, std::is_same<decltype(*reps_), decltype(*param_types.data())>::value,
"type mismatch, cannot memcpy"); "type mismatch, cannot memcpy");
memcpy(storage_ + kReturnCount, param_types.data(), if (kParamCount > 0) {
sizeof(*storage_) * kParamCount); memcpy(storage_ + kReturnCount, param_types.data(),
sizeof(*storage_) * kParamCount);
}
} }
private: private: