From 58836f7327af6333b337d0f2e762e2db07ad8f9e Mon Sep 17 00:00:00 2001 From: Camillo Bruni Date: Tue, 29 Mar 2022 12:13:24 +0200 Subject: [PATCH] [api] Add warning comment about changing FatalProcessOutOfMemory MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The signature of FatalProcessOutOfMemory is used extracting V8 specific crash information from chrome minidumps. Change-Id: I625a9ca1f1628c6ddd34cf794cc4205b012ef23e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3532267 Reviewed-by: Michael Lippautz Reviewed-by: Marja Hölttä Commit-Queue: Camillo Bruni Cr-Commit-Position: refs/heads/main@{#79650} --- src/init/v8.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/init/v8.h b/src/init/v8.h index 3f8fe14b45..8184e16b03 100644 --- a/src/init/v8.h +++ b/src/init/v8.h @@ -24,6 +24,8 @@ class V8 : public AllStatic { // Report process out of memory. Implementation found in api.cc. // This function will not return, but will terminate the execution. + // IMPORTANT: Update the Google-internal crash processer if this signature + // changes to be able to extract detailed v8::internal::HeapStats on OOM. [[noreturn]] static void FatalProcessOutOfMemory(Isolate* isolate, const char* location, bool is_heap_oom = false);