AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Force SharedFunctionInfo::name() to be a flat string

Browse Source 
This fact is depended upon by, at least, Parser::ParseLazy, and quite
likely by other code. There was already code in %FunctionSetName
enforcing this invariant. This patch adds similar code to
Factory::NewSharedFunctionInfo().

BUG=v8:4659
LOG=n

Review URL: https://codereview.chromium.org/1686193003

Cr-Commit-Position: refs/heads/master@{#33914}
This commit is contained in:
adamk 2016-02-11 10:52:27 -08:00 committed by Commit bot
parent 8eaf90b82c
commit 58a9bc5b53
2 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/factory.cc
View File

@ -2116,6 +2116,7 @@ Handle<SharedFunctionInfo> Factory::NewSharedFunctionInfo(
Handle<SharedFunctionInfo> share = New<SharedFunctionInfo>(map, OLD_SPACE);
// Set pointer fields.
name = String::Flatten(name, TENURED);
share->set_name(*name);
Handle<Code> code;
if (!maybe_code.ToHandle(&code)) {

12
test/mjsunit/regress/regress-4659.js Normal file
View File

@ -0,0 +1,12 @@
// Copyright 2016 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// Flags: --harmony-function-name
var obj = {
get longerName(){
return 42;
}
};
assertEquals(42, obj.longerName);